Fix Swap Sort Implementation: Correct Logic and Improve Efficiency

Author: Alex Klymenko

src/main/java/com/thealgorithms/sorts/SwapSort.java

@@ -9,64 +9,25 @@
  */
 public class SwapSort implements SortAlgorithm {
 
+    /**
+     * Sorts the input array using the swap sort algorithm.
+     *
+     * @param array the array to be sorted
+     * @param <T>   the type of elements in the array, which must be Comparable
+     * @return the sorted array
+     */
     @Override
     public <T extends Comparable<T>> T[] sort(T[] array) {
         int len = array.length;
-        int index = 0;
 
-        while (index < len - 1) {
-            int amountSmallerElements = this.getSmallerElementCount(array, index);
-
-            if (amountSmallerElements > 0 && index != amountSmallerElements) {
-                SortUtils.swap(array, index, amountSmallerElements);
-            } else {
-                index++;
+        for (int i = 0; i < len - 1; i++) {
+            for (int j = i + 1; j < len; j++) {
+                if (SortUtils.less(array[j], array[i])) {
+                    SortUtils.swap(array, i, j);
+                }
             }
         }
 
         return array;
     }
-
-    private <T extends Comparable<T>> int getSmallerElementCount(T[] array, int index) {
-        int counter = 0;
-        for (int i = 0; i < array.length; i++) {
-            if (SortUtils.less(array[i], array[index])) {
-                counter++;
-            }
-        }
-
-        return counter;
-    }
-
-    public static void main(String[] args) {
-        // ==== Int =======
-        Integer[] a = {3, 7, 45, 1, 33, 5, 2, 9};
-        System.out.print("unsorted: ");
-        SortUtils.print(a);
-        System.out.println();
-
-        new SwapSort().sort(a);
-        System.out.print("sorted: ");
-        SortUtils.print(a);
-        System.out.println();
-
-        // ==== String =======
-        String[] b = {
-            "banana",
-            "berry",
-            "orange",
-            "grape",
-            "peach",
-            "cherry",
-            "apple",
-            "pineapple",
-        };
-        System.out.print("unsorted: ");
-        SortUtils.print(b);
-        System.out.println();
-
-        new SwapSort().sort(b);
-        System.out.print("sorted: ");
-        SortUtils.print(b);
-    }
 }

src/test/java/com/thealgorithms/sorts/SwapSortTest.java

@@ -0,0 +1,8 @@
+package com.thealgorithms.sorts;
+
+public class SwapSortTest extends SortingAlgorithmTest {
+    @Override
+    SortAlgorithm getSortAlgorithm() {
+        return new SwapSort();
+    }
+}