refactor

Author: Samuel Facchinello

src/main/java/com/thealgorithms/backtracking/Combination.java

@@ -1,60 +1,58 @@
 package com.thealgorithms.backtracking;
 
-import java.util.Arrays;
-import java.util.LinkedList;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.TreeSet;
 
 /**
- * Finds all permutations of given array
- * @author Alan Piao (<a href="https://github.com/cpiao3">git-Alan Piao</a>)
+ * Finds all combinations of a given array of unique elements.
  */
 public final class Combination {
     private Combination() {
     }
 
-    private static int length;
-
     /**
-     * Find all combinations of given array using backtracking
-     * @param arr the array.
-     * @param n length of combination
-     * @param <T> the type of elements in the array.
-     * @return a list of all combinations of length n. If n == 0, return null.
+     * Finds all combinations of a given array of length n.
+     * If n is 0, an empty list is returned.
+     *
+     * @param data            the array of elements.
+     * @param combinationSize the desired size of combinations.
+     * @param <T>             the type of elements in the array (assumed to be unique).
+     * @return a list of all combinations of size `combinationSize`.
+     * @throws IllegalArgumentException if combinationSize is negative.
      */
-    public static <T> List<TreeSet<T>> combination(T[] arr, int n) {
-        if (n == 0) {
+    public static <T> List<TreeSet<T>> combination(T[] data, int combinationSize) {
+        if (combinationSize < 0) {
+            throw new IllegalArgumentException("Combination size cannot be negative.");
+        } else if (combinationSize == 0) {
             return null;
         }
-        length = n;
-        T[] array = arr.clone();
-        Arrays.sort(array);
-        List<TreeSet<T>> result = new LinkedList<>();
-        backtracking(array, 0, new TreeSet<T>(), result);
-        return result;
+
+        List<TreeSet<T>> combinations = new ArrayList<>();
+        findCombinationsRecursive(data, 0, new ArrayList<>(), combinations, combinationSize);
+        return combinations;
     }
 
     /**
-     * Backtrack all possible combinations of a given array
-     * @param arr the array.
-     * @param index the starting index.
-     * @param currSet set that tracks current combination
-     * @param result the list contains all combination.
+     * Recursive helper function to find combinations using backtracking.
+     *
+     * @param data the array of elements.
+     * @param startIndex the starting index for the current combination.
+     * @param currentCombination the current combination being built.
+     * @param combinations the list to store all found combinations.
+     * @param combinationSize the desired size of combinations.
      * @param <T> the type of elements in the array.
      */
-    private static <T> void backtracking(T[] arr, int index, TreeSet<T> currSet, List<TreeSet<T>> result) {
-        if (index + length - currSet.size() > arr.length) return;
-        if (length - 1 == currSet.size()) {
-            for (int i = index; i < arr.length; i++) {
-                currSet.add(arr[i]);
-                result.add((TreeSet<T>) currSet.clone());
-                currSet.remove(arr[i]);
-            }
+    private static <T> void findCombinationsRecursive(T[] data, int startIndex, List<T> currentCombination, List<TreeSet<T>> combinations, int combinationSize) {
+        if (currentCombination.size() == combinationSize) {
+            combinations.add(new TreeSet<>(currentCombination)); // Deep copy to avoid modification
+            return;
         }
-        for (int i = index; i < arr.length; i++) {
-            currSet.add(arr[i]);
-            backtracking(arr, i + 1, currSet, result);
-            currSet.remove(arr[i]);
+
+        for (int i = startIndex; i < data.length; i++) {
+            currentCombination.add(data[i]);
+            findCombinationsRecursive(data, i + 1, currentCombination, combinations, combinationSize);
+            currentCombination.removeLast();
         }
     }
 }

src/test/java/com/thealgorithms/backtracking/CombinationTest.java

@@ -1,5 +1,7 @@
 package com.thealgorithms.backtracking;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.List;
@@ -11,21 +13,23 @@ public class CombinationTest {
     @Test
     void testNoElement() {
         List<TreeSet<Integer>> result = Combination.combination(new Integer[] {1, 2}, 0);
-        assertTrue(result == null);
+        assertNull(result);
     }
 
     @Test
     void testLengthOne() {
         List<TreeSet<Integer>> result = Combination.combination(new Integer[] {1, 2}, 1);
-        assertTrue(result.get(0).iterator().next() == 1);
-        assertTrue(result.get(1).iterator().next() == 2);
+        assert result != null;
+        assertEquals(1, (int) result.get(0).getFirst());
+        assertEquals(2, (int) result.get(1).getFirst());
     }
 
     @Test
     void testLengthTwo() {
         List<TreeSet<Integer>> result = Combination.combination(new Integer[] {1, 2}, 2);
-        Integer[] arr = result.get(0).toArray(new Integer[2]);
-        assertTrue(arr[0] == 1);
-        assertTrue(arr[1] == 2);
+        assert result != null;
+        Integer[] arr = result.getFirst().toArray(new Integer[2]);
+        assertEquals(1, (int) arr[0]);
+        assertEquals(2, (int) arr[1]);
     }
 }