Skip to content

Add branch protection rules #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Panquesito7 opened this issue Jun 23, 2020 · 4 comments
Closed

Add branch protection rules #887

Panquesito7 opened this issue Jun 23, 2020 · 4 comments
Labels
enhancement New feature or request stale Author has not responded to the comments for over 2 weeks

Comments

@Panquesito7
Copy link
Member

It would be nice if this repository could have branch protection rules such as required commit signing, required status checks to pass, and also require at least one approving review.

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 23, 2020
@kvedala
Copy link
Collaborator

kvedala commented Jun 28, 2020

good points. Let us ask ourselves:

  1. do we foresee, in the current execution, any issues with corrupting the branches?
  2. what value does commit signing add to us?
  3. with Major rework to improve code quality and add automation checks #805 merged, status checks are now in place. what additional ones do we need?

Could you answer the above points?

@Panquesito7
Copy link
Member Author

  1. do we foresee, in the current execution, any issues with corrupting the branches?

Something wrong can happen with the branches.
It can happen that, you can corrupt branches when pushing from a different branch, to a different branch with a force-push. That will surely corrupt a branch.

2. what value does commit signing add to us?

You can create commits as another person.
The commit is not verified, and you cannot verify it.

Of course, that is not so common, however you don't know when that can happen.
If the commit is verified, you can trust he is the original committer.

3. with #805 merged, status checks are now in place. what additional ones do we need?

I think you misunderstood my comment.
If you enable the required status checks option, all checks must pass in order to get a PR merged.

@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Author has not responded to the comments for over 2 weeks label Mar 20, 2021
@Panquesito7
Copy link
Member Author

This has been implemented already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Development

No branches or pull requests

2 participants