Skip to content

Commit ecc9099

Browse files
committed
Revert 86721d1
PR rust-lang#817 (and commit 86721d1) are based on the false premise that ABI changes == API changes. This commit did not solve any issues, because the only reason git2-rs would be incompatible to compile with a new version of the system libgit2 would be if there was an *API* change. While libgit2 does have an unstable ABI when it comes to major releases, they do not have an unstable API. This means that system versions above what the library is "currently compatible with" can take advantage of the newer library version with minimal changes, there will just need to be a recompile. Again, all this commit did was artificially limit the newer versions of libgit2 you can use with this library and not didn't solve anything. Programs will still need a recompile, and git2-rs will need a version bump simply to increase this number.
1 parent 04278a2 commit ecc9099

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

libgit2-sys/build.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ fn main() {
1414
let try_to_use_system_libgit2 = !vendored && !zlib_ng_compat;
1515
if try_to_use_system_libgit2 {
1616
let mut cfg = pkg_config::Config::new();
17-
if let Ok(lib) = cfg.range_version("1.4.4".."1.5.0").probe("libgit2") {
17+
if let Ok(lib) = cfg.atleast_version("1.4.4").probe("libgit2") {
1818
for include in &lib.include_paths {
1919
println!("cargo:root={}", include.display());
2020
}

0 commit comments

Comments
 (0)