Skip to content

Commit 8eff203

Browse files
committed
docs: Set minimum versions for sphinx
I saw that the build was failing, hence this is my attempt to fix it, altough I don't know how to test this before merging it. See https://readthedocs.org/projects/luigi/builds/4189801/ Unfortunately I couldn't find a way to connect a webhook between GitHub PRs and readthedocs: readthedocs/readthedocs.org#1340 The reason I believe a version bump would fix it is because I see exactly the same error as in sphinx-doc/sphinx#2465 and readthedocs seem to use 1.3.5, causing the pdf docs to be outdated.
1 parent 6d4dbf0 commit 8eff203

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

doc/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def _warn_node(self, msg, node, *args, **kwargs):
8282
# -- General configuration ------------------------------------------------
8383

8484
# If your documentation needs a minimal Sphinx version, state it here.
85-
#needs_sphinx = '1.0'
85+
needs_sphinx = '1.4.4'
8686

8787
# Add any Sphinx extension module names here, as strings. They can be
8888
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ commands = isort -w 120 -rc luigi test examples bin
8787
# Call this using `tox -e docs`.
8888
deps =
8989
sqlalchemy
90-
Sphinx==1.4.2
90+
Sphinx>=1.4.4<1.5
9191
sphinx_rtd_theme
9292
commands =
9393
# build API docs

0 commit comments

Comments
 (0)