Merge branch 'max/gcs-signed-headers' into 'master'

chore(gcs): let the server sign and return the "x-goog-meta-tanker-metadata" header

See merge request Tanker/sdk-js!473

Author: Maxime Réty

packages/core/src/CloudStorage/Manager.js

@@ -81,7 +81,7 @@ export class CloudStorageManager {
     const { UploadStream } = streamService;
 
     const slicer = new SlicerStream({ source: clearData });
-    const uploader = new UploadStream(urls, headers, totalEncryptedSize, recommendedChunkSize, encryptedMetadata);
+    const uploader = new UploadStream(urls, headers, totalEncryptedSize, recommendedChunkSize);
 
     const progressHandler = new ProgressHandler(progressOptions).start(totalEncryptedSize);
     uploader.on('uploaded', (chunk: Uint8Array) => progressHandler.report(chunk.byteLength));

packages/stream/cloud-storage/src/gcs/UploadStream.js

@@ -17,14 +17,14 @@ export class UploadStream extends Writable {
   _uploadedLength: number;
   _verbose: bool;
 
-  constructor(urls: Array<string>, headers: Object, contentLength: number, _recommendedChunkSize: number, encryptedMetadata: string, verbose: bool = false) {
+  constructor(urls: Array<string>, headers: Object, contentLength: number, _recommendedChunkSize: number, verbose: bool = false) {
     super({
       highWaterMark: 1,
       objectMode: true
     });
 
     this._initUrl = urls[0];
-    this._headers = { ...headers, 'x-goog-meta-tanker-metadata': encryptedMetadata };
+    this._headers = { ...headers }; // copy
     this._contentLength = contentLength;
     this._uploadedLength = 0;
     this._verbose = verbose;
@@ -40,7 +40,6 @@ export class UploadStream extends Writable {
 
   async initialize() {
     this.log('initializing...');
-
     const { ok, status, statusText, headers } = await fetch(this._initUrl, { method: 'POST', headers: this._headers });
     if (!ok) {
       throw new NetworkError(`GCS init request failed with status ${status}: ${statusText}`);

packages/stream/cloud-storage/src/s3/UploadStream.js

@@ -14,7 +14,7 @@ export class UploadStream extends Writable {
   _recommendedChunkSize: number;
   _verbose: bool;
 
-  constructor(urls: Array<string>, headers: Object, contentLength: number, recommendedChunkSize: number, encryptedMetadata: string, verbose: bool = false) {
+  constructor(urls: Array<string>, headers: Object, contentLength: number, recommendedChunkSize: number, verbose: bool = false) {
     super({
       highWaterMark: 1,
       objectMode: true