standard

Author: Takazudo

functions/tweet-to-trello/tweet-to-trello.js

@@ -1,5 +1,3 @@
-const fetch = require('node-fetch')
-
 const {
   createParams,
   fetchHtml,
@@ -12,10 +10,9 @@ const {
 } = require('./utils')
 
 exports.handler = async (event, context) => {
-
   console.log('=== request accepted ===')
 
-  if (event.httpMethod !== 'POST'){
+  if (event.httpMethod !== 'POST') {
     console.log('ERR: method is not post')
     return {
       statusCode: 400,
@@ -24,11 +21,11 @@ exports.handler = async (event, context) => {
   }
 
   const bodyFormat = event.headers['x-bodyformat'] || 'TEXT'
-  const converter = bodyFormat === 'JSON' ? createDataFromJSON : createDataFromBodyText;
+  const converter = bodyFormat === 'JSON' ? createDataFromJSON : createDataFromBodyText
   const { tweetText, urlSource, appSecret } = converter(event.body)
 
   // check params
-  if(!urlSource || !appSecret) {
+  if (!urlSource || !appSecret) {
     console.log('ERR: params not enough')
     return {
       statusCode: 400,
@@ -37,21 +34,20 @@ exports.handler = async (event, context) => {
   }
 
   // need valid appSecret
-  if(!isValidSecret(appSecret)) {
+  if (!isValidSecret(appSecret)) {
     console.log('ERR: invalid appSecret')
     return {
       statusCode: 400,
       body: 'invalid appSecret'
     }
   }
 
-  let formattedPageText;
+  let formattedPageText
 
   try {
     // fetch target page's html as text
     const html = await fetchHtml(urlSource)
     formattedPageText = createFormattedTextFromHtml(html)
-
   } catch (err) {
     console.log('ERR: fetching page failed')
     console.log(err)
@@ -77,19 +73,21 @@ exports.handler = async (event, context) => {
       console.log('ERR: trello api says response.ok is false')
       // NOT res.status >= 200 && res.status < 300
       const data = await response.json()
+      console.log(data)
       return {
         statusCode: response.status,
         body: response.statusText
       }
     }
 
-    const data = await response.json()
+    // const data = await response.json()
 
     console.log('DONE: succeeded')
     // succeeded!
     return {
       statusCode: 200,
-      body: '' //JSON.stringify(data)
+      body: ''
+      // body: JSON.stringify(data)
     }
   } catch (err) {
     // something wrong
@@ -100,5 +98,4 @@ exports.handler = async (event, context) => {
       body: JSON.stringify({ msg: err.message }) // Could be a custom message or object i.e. JSON.stringify(err)
     }
   }
-
 }

functions/tweet-to-trello/utils.js

@@ -1,19 +1,19 @@
 require('dotenv').config()
-const { URLSearchParams } = require('url');
+const { URLSearchParams } = require('url')
 const fetch = require('node-fetch')
 const parseHtml = require('node-html-parser').parse
 const frontMatter = require('front-matter')
 
 const {
   TRELLO_API_KEY: key,
   TRELLO_API_TOKEN: token,
-  TRELLO_LIST_ID_NEW_CARD_TO_BE_APPENDED: list_id_tweet,
-  TRELLO_LIST_ID_IOS: list_id_ios,
+  TRELLO_LIST_ID_NEW_CARD_TO_BE_APPENDED: listIdTweet,
+  TRELLO_listIdIos: listIdIos,
   TWEET_TO_TRELLO_SECRET: correctAppSecret
 } = process.env
 
 module.exports.isValidSecret = appSecret => {
-  if(appSecret !== correctAppSecret) return false
+  if (appSecret !== correctAppSecret) return false
   return true
 }
 
@@ -44,9 +44,9 @@ ${a[2]}`
 
 module.exports.createParams = ({ desc, urlSource, fromTweet, fromIos }) => {
   const params = new URLSearchParams()
-  const list_id = fromTweet ? list_id_tweet : list_id_ios
+  const listId = fromTweet ? listIdTweet : listIdIos
   params.append('pos', 'top')
-  params.append('idList', list_id)
+  params.append('idList', listId)
   params.append('key', key)
   params.append('token', token)
   params.append('desc', desc)
@@ -68,7 +68,7 @@ module.exports.createFormattedTextFromHtml = html => {
     script: false,
     style: false,
     pre: true,
-    comment: false,
+    comment: false
   }
   // parsed should be a formatted DOM element that node-html-parser generates
   const parsed = parseHtml(html, options)
@@ -79,8 +79,8 @@ module.exports.createFormattedTextFromHtml = html => {
 }
 
 module.exports.combineText = (tweetText, pageText) => {
-  let text;
-  if(tweetText) {
+  let text
+  if (tweetText) {
     text = `${tweetText}\n\n---\n\n${pageText}`
   } else {
     text = pageText
@@ -89,9 +89,10 @@ module.exports.combineText = (tweetText, pageText) => {
 }
 
 module.exports.createTrelloCard = async params => {
-  return await fetch('https://api.trello.com/1/cards', {
+  const response = await fetch('https://api.trello.com/1/cards', {
     method: 'post',
     headers: { Accept: 'application/json' },
     body: params
   })
+  return response
 }