Skip to content

Commit ad84eb8

Browse files
authored
Merge pull request letscontrolit#1696 from TD-er/feature/leading_zero_sysvars
[sysvar] rename vars with leading zero to %..._0%
2 parents 34d2f25 + 23f2bfc commit ad84eb8

File tree

2 files changed

+32
-17
lines changed

2 files changed

+32
-17
lines changed

src/StringConverter.ino

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -513,16 +513,25 @@ void parseSystemVariables(String& s, boolean useURLencode)
513513
// valueString is being used by the macro.
514514
char valueString[5];
515515
#define SMART_REPL_TIME(T,F,V) if (s.indexOf(T) != -1) { sprintf_P(valueString, (F), (V)); repl((T),valueString, s, useURLencode);}
516-
SMART_REPL_TIME(F("%syshour%"), PSTR("%02d"), hour())
517-
SMART_REPL_TIME(F("%sysmin%"), PSTR("%02d"), minute())
518-
SMART_REPL_TIME(F("%syssec%"),PSTR("%02d"), second())
516+
SMART_REPL_TIME(F("%sysyear%"), PSTR("%d"), year())
517+
SMART_REPL_TIME(F("%sysmonth%"),PSTR("%d"), month())
518+
SMART_REPL_TIME(F("%sysday%"), PSTR("%d"), day())
519+
SMART_REPL_TIME(F("%syshour%"), PSTR("%d"), hour())
520+
SMART_REPL_TIME(F("%sysmin%"), PSTR("%d"), minute())
521+
SMART_REPL_TIME(F("%syssec%"),PSTR("%d"), second())
519522
SMART_REPL_TIME(F("%syssec_d%"),PSTR("%d"), ((hour()*60) + minute())*60 + second());
520-
SMART_REPL_TIME(F("%sysday%"), PSTR("%02d"), day())
521-
SMART_REPL_TIME(F("%sysmonth%"),PSTR("%02d"), month())
522-
SMART_REPL_TIME(F("%sysyear%"), PSTR("%04d"), year())
523-
SMART_REPL_TIME(F("%sysyears%"),PSTR("%02d"), year()%100)
524523
SMART_REPL(F("%sysweekday%"), String(weekday()))
525524
SMART_REPL(F("%sysweekday_s%"), weekday_str())
525+
526+
// With leading zero
527+
SMART_REPL_TIME(F("%sysyears%"),PSTR("%02d"), year()%100)
528+
SMART_REPL_TIME(F("%sysyear_0%"), PSTR("%04d"), year())
529+
SMART_REPL_TIME(F("%syshour_0%"), PSTR("%02d"), hour())
530+
SMART_REPL_TIME(F("%sysday_0%"), PSTR("%02d"), day())
531+
SMART_REPL_TIME(F("%sysmin_0%"), PSTR("%02d"), minute())
532+
SMART_REPL_TIME(F("%syssec_0%"),PSTR("%02d"), second())
533+
SMART_REPL_TIME(F("%sysmonth_0%"),PSTR("%02d"), month())
534+
526535
#undef SMART_REPL_TIME
527536
}
528537
SMART_REPL(F("%lcltime%"), getDateTimeString('-',':',' '))

src/WebServer.ino

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5423,10 +5423,14 @@ void handle_sysvars() {
54235423

54245424
addHeader(true, TXBuffer.buf);
54255425

5426-
TXBuffer += F("<p>This page may load slow. Do not load too often, since it may affect performance of the node.</p>");
5426+
html_BR();
5427+
TXBuffer += F("<p>This page may load slow.<BR>Do not load too often, since it may affect performance of the node.</p>");
5428+
html_BR();
54275429

54285430
// the table header
54295431
TXBuffer += F("<table class='normal'><TR><TH align='left'>System Variables<TH align='left'>Normal<TH align='left'>URL encoded");
5432+
addHelpButton(F("ESPEasy_System_Variables"));
5433+
54305434
addTableSeparator(F("Constants"), 3, 3);
54315435
addSysVar_html(F("%CR%"));
54325436
addSysVar_html(F("%LF%"));
@@ -5456,22 +5460,24 @@ void handle_sysvars() {
54565460
#endif
54575461

54585462
addTableSeparator(F("Time"), 3, 3);
5463+
addSysVar_html(F("%lcltime%"));
5464+
addSysVar_html(F("%lcltime_am%"));
54595465
addSysVar_html(F("%systm_hm%"));
54605466
addSysVar_html(F("%systm_hm_am%"));
54615467
addSysVar_html(F("%systime%"));
54625468
addSysVar_html(F("%systime_am%"));
5463-
addSysVar_html(F("%syshour%"));
5464-
addSysVar_html(F("%sysmin%"));
5465-
addSysVar_html(F("%syssec%"));
5466-
addSysVar_html(F("%syssec_d%"));
5467-
addSysVar_html(F("%sysday%"));
5468-
addSysVar_html(F("%sysmonth%"));
5469-
addSysVar_html(F("%sysyear%"));
5469+
addTableSeparator(F("System"), 3, 3);
5470+
addSysVar_html(F("%sysyear% // %sysyear_0%"));
54705471
addSysVar_html(F("%sysyears%"));
5472+
addSysVar_html(F("%sysmonth% // %sysmonth_0%"));
5473+
addSysVar_html(F("%sysday% // %sysday_0%"));
5474+
addSysVar_html(F("%syshour% // %syshour_0%"));
5475+
addSysVar_html(F("%sysmin% // %sysmin_0%"));
5476+
addSysVar_html(F("%syssec% // %syssec_0%"));
5477+
addSysVar_html(F("%syssec_d%"));
54715478
addSysVar_html(F("%sysweekday%"));
54725479
addSysVar_html(F("%sysweekday_s%"));
5473-
addSysVar_html(F("%lcltime%"));
5474-
addSysVar_html(F("%lcltime_am%"));
5480+
addTableSeparator(F("System"), 3, 3);
54755481
addSysVar_html(F("%uptime%"));
54765482
addSysVar_html(F("%unixtime%"));
54775483
addSysVar_html(F("%sunset%"));

0 commit comments

Comments
 (0)