Skip to content

Commit a0f3b8c

Browse files
committed
Add author to changed classes. Remove integration test.
The test cannot be reproduced using hsqldb - the syntax causing the bug is not supported. Closes spring-projects#2260
1 parent 6810887 commit a0f3b8c

File tree

4 files changed

+3
-13
lines changed

4 files changed

+3
-13
lines changed

src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
* @author Mohammad Hewedy
7474
* @author Andriy Redko
7575
* @author Peter Großmann
76+
* @author Jędrzej Biedrzycki
7677
*/
7778
public abstract class QueryUtils {
7879

src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java

-9
Original file line numberDiff line numberDiff line change
@@ -693,15 +693,6 @@ void readsPageWithGroupByClauseCorrectly() {
693693
assertThat(result.getTotalPages()).isEqualTo(1);
694694
}
695695

696-
@Test
697-
void readsPageWithDenseRankClauseCorrectly() {
698-
699-
flushTestUsers();
700-
701-
Page<Integer> result = repository.findDenseRankByLastnameGrouped(PageRequest.of(0, 10, Sort.by(Order.desc("username"))));
702-
assertThat(result.getTotalPages()).isEqualTo(1);
703-
}
704-
705696
@Test
706697
void executesLessThatOrEqualQueriesCorrectly() {
707698

src/test/java/org/springframework/data/jpa/repository/query/QueryUtilsUnitTests.java

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
* @author Florian Lüdiger
4040
* @author Grégoire Druant
4141
* @author Mohammad Hewedy
42+
* @author Jędrzej Biedrzycki
4243
*/
4344
class QueryUtilsUnitTests {
4445

src/test/java/org/springframework/data/jpa/repository/sample/UserRepository.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public interface UserRepository
9090
*/
9191
User findByEmailAddress(String emailAddress);
9292

93-
@Query("select u from User u left outer join u.manager as manager") // TODO: reuse
93+
@Query("select u from User u left outer join u.manager as manager")
9494
Page<User> findAllPaged(Pageable pageable);
9595

9696
/**
@@ -223,9 +223,6 @@ public interface UserRepository
223223
@Query("select u.lastname from User u group by u.lastname")
224224
Page<String> findByLastnameGrouped(Pageable pageable);
225225

226-
@Query(value = "select row_number() over (order by u.lastname) from user u", nativeQuery = true)
227-
Page<Integer> findDenseRankByLastnameGrouped(Pageable pageable);
228-
229226
// DATAJPA-117
230227
@Query(value = "SELECT * FROM SD_User WHERE lastname = ?1", nativeQuery = true)
231228
List<User> findNativeByLastname(String lastname);

0 commit comments

Comments
 (0)