Merge pull request verilog-to-routing#811 from j-b-1-7/odin_coverity_issue_200770

jeanlego · web-flow · commit 764317947302 · 2019-07-27T11:46:09.000-03:00
ODIN_II: Fix coverity issue CID 200770: Resource leak
diff --git a/ODIN_II/SRC/netlist_visualizer.cpp b/ODIN_II/SRC/netlist_visualizer.cpp
@@ -316,7 +316,6 @@ void forward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t *
 
 /*---------------------------------------------------------------------------------------------
  * (function: backward_traversal_net_graph_display()
- *	TODO check if stack of node is freed
  *-------------------------------------------------------------------------------------------*/
 void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t *node)
 {
@@ -399,4 +398,10 @@ void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t
 		/* process next element in net */
 		index_in_stack ++;
 	}
+	
+	for(int i = 0; i < num_stack_of_nodes; i++)
+	{
+		free_nnode(stack_of_nodes[i]);
+	}
+	vtr::free(stack_of_nodes);
 }

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,6 @@ void forward_traversal_net_graph_display(FILE fp, short marker_value, nnode_t `
`316`	`316`
`317`	`317`	`/*---------------------------------------------------------------------------------------------`
`318`	`318`	`* (function: backward_traversal_net_graph_display()`
`319`		`- * TODO check if stack of node is freed`
`320`	`319`	`-------------------------------------------------------------------------------------------/`
`321`	`320`	`void backward_traversal_net_graph_display(FILE fp, short marker_value, nnode_t node)`
`322`	`321`	`{`
`@@ -399,4 +398,10 @@ void backward_traversal_net_graph_display(FILE *fp, short marker_value, nnode_t`
`399`	`398`	`/* process next element in net */`
`400`	`399`	`index_in_stack ++;`
`401`	`400`	`}`
	`401`	`+`
	`402`	`+ for(int i = 0; i < num_stack_of_nodes; i++)`
	`403`	`+ {`
	`404`	`+ free_nnode(stack_of_nodes[i]);`
	`405`	`+ }`
	`406`	`+ vtr::free(stack_of_nodes);`
`402`	`407`	`}`