Refute claims made in SPR-9051

It was claimed that when a {@code @ContextConfiguration} test class
references a config class missing an {@code @configuration} annotation,
@bean dependencies are wired successfully but the bean lifecycle is not
applied (no init methods are invoked, for example).

AnnotatedConfigClassesWithoutAtConfigurationTests refutes this claim by
demonstrating that @bean methods in non-@configuration classes are
properly handled as "annotated factory bean methods" and that lifecycle
callbacks in fact apply to such factory beans.

Issue: SPR-9051

Author: sbrannen

spring-test/src/test/java/org/springframework/test/context/junit4/profile/importresource/DefaultProfileAnnotationConfigTests.java

@@ -16,24 +16,24 @@
 
 package org.springframework.test.context.junit4.profile.importresource;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+
 import org.junit.Test;
 import org.junit.runner.RunWith;
-
 import org.springframework.beans.Employee;
 import org.springframework.beans.Pet;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
-import org.springframework.test.context.support.AnnotationConfigContextLoader;
-
-import static org.junit.Assert.*;
 
 /**
  * @author Juergen Hoeller
  * @since 3.1
  */
 @RunWith(SpringJUnit4ClassRunner.class)
-@ContextConfiguration(classes = DefaultProfileConfig.class, loader = AnnotationConfigContextLoader.class)
+@ContextConfiguration(classes = DefaultProfileConfig.class)
 public class DefaultProfileAnnotationConfigTests {
 
 	@Autowired

spring-test/src/test/java/org/springframework/test/context/junit4/spr9051/AnnotatedConfigClassesWithoutAtConfigurationTests.java

@@ -0,0 +1,102 @@
+/*
+ * Copyright 2002-2012 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.test.context.junit4.spr9051;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.Bean;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
+
+/**
+ * This set of tests refutes the claims made in
+ * <a href="https://jira.springsource.org/browse/SPR-9051" target="_blank">SPR-9051</a>.
+ * 
+ * <p><b>The Claims</b>:
+ * 
+ * <blockquote>
+ * When a {@code @ContextConfiguration} test class references a config class
+ * missing an {@code @Configuration} annotation, {@code @Bean} dependencies are
+ * wired successfully but the bean lifecycle is not applied (no init methods are
+ * invoked, for example). Adding the missing {@code @Configuration} annotation
+ * solves the problem, however the problem and solution isn't obvious since 
+ * wiring/injection appeared to work.
+ * </blockquote>
+ * 
+ * @author Sam Brannen
+ * @since 3.2
+ */
+@RunWith(SpringJUnit4ClassRunner.class)
+@ContextConfiguration(classes = AnnotatedConfigClassesWithoutAtConfigurationTests.AnnotatedFactoryBeans.class)
+public class AnnotatedConfigClassesWithoutAtConfigurationTests {
+
+	/**
+	 * This is intentionally <b>not</b> annotated with {@code @Configuration}.
+	 * Consequently, this class contains what we call <i>annotated factory bean
+	 * methods</i> instead of standard bean definition methods.
+	 */
+	static class AnnotatedFactoryBeans {
+
+		static final AtomicInteger enigmaCallCount = new AtomicInteger();
+
+
+		@Bean
+		public String enigma() {
+			return "enigma #" + enigmaCallCount.incrementAndGet();
+		}
+
+		@Bean
+		public LifecycleBean lifecycleBean() {
+			// The following call to enigma() literally invokes the local
+			// enigma() method, not a CGLIB proxied version, since these methods
+			// are essentially factory bean methods.
+			LifecycleBean bean = new LifecycleBean(enigma());
+			assertFalse(bean.isInitialized());
+			return bean;
+		}
+	}
+
+
+	@Autowired
+	private String enigma;
+
+	@Autowired
+	private LifecycleBean lifecycleBean;
+
+
+	@Test
+	public void simpleStringBean() {
+		assertNotNull(enigma);
+		assertEquals("enigma #1", enigma);
+	}
+
+	@Test
+	public void beanWithLifecycleCallback() {
+		assertNotNull(lifecycleBean);
+		assertEquals("enigma #2", lifecycleBean.getName());
+		assertTrue(lifecycleBean.isInitialized());
+	}
+
+}

spring-test/src/test/java/org/springframework/test/context/junit4/spr9051/LifecycleBean.java

@@ -0,0 +1,51 @@
+/*
+ * Copyright 2002-2012 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.test.context.junit4.spr9051;
+
+import javax.annotation.PostConstruct;
+
+/**
+ * Simple POJO that contains lifecycle callbacks.
+ * 
+ * @author Sam Brannen
+ * @since 3.2
+ */
+public class LifecycleBean {
+
+	private final String name;
+
+	private boolean initialized = false;
+
+
+	public LifecycleBean(String name) {
+		this.name = name;
+	}
+
+	public String getName() {
+		return this.name;
+	}
+
+	@PostConstruct
+	public void init() {
+		initialized = true;
+	}
+
+	public boolean isInitialized() {
+		return this.initialized;
+	}
+
+}