Skip to content

folder name starting with 'eclipse-' corrupted in makefile #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JAndrassy opened this issue Mar 7, 2020 · 9 comments
Closed

folder name starting with 'eclipse-' corrupted in makefile #1153

JAndrassy opened this issue Mar 7, 2020 · 9 comments
Labels
domain: build The build does not work as the Arduino IDE.

Comments

@JAndrassy
Copy link

JAndrassy commented Mar 7, 2020

Nightly plugin version 4.3.3.202003070521 and current HEAD generates to makefile

AR += \
/home/duro/eclipse/-workspace/Test3/Release/arduino.ar \

/home/duro/eclipse/-workspace/Test3/Release/arduino.ar: $(AR_OBJ)
	@echo 'Starting archiver'

the right folder should be eclipse-workspace. folder /home/duro/eclipse exists too. then

     /home/duro/eclipse/-workspace/Test3/Release/arduino.ar: No such file or directory
makefile:73: recipe for target '/home/duro/eclipse/-workspace/Test3/Release/arduino.ar' failed

for other workspace folder with - the makefile is ok.

AR += \
/home/duro/runtime-EclipseApplication/Blink/Release/arduino.ar \

EDIT .settings/org.eclipse.cdt.core.prefs contains

environment/project/io.sloeber.core.toolChain.release.1221121858/A.BUILD.PATH/value=${eclipse_home}-workspace/Test3/Release

the other project has a full path

environment/project/io.sloeber.core.toolChain.release.366347866/A.BUILD.PATH/value=/home/duro/runtime-EclipseApplication/Blink/Release
@JAndrassy JAndrassy changed the title folder folder name containing '-' corrupted in makefile Mar 7, 2020
@jantje
Copy link
Member

jantje commented Mar 7, 2020

As I have seen - being used in both project name and in folder names I guess this problem only occurs in workspace names.

@JAndrassy
Copy link
Author

JAndrassy commented Mar 8, 2020

the problem is in .settings/org.eclipse.cdt.core.prefs
A.BUILD.PATH/value=${eclipse_home}-workspace/Test3/Release
part of the path is missmatched as a variable
the other project has a full path
A.BUILD.PATH/value=/home/duro/runtime-EclipseApplication/Blink/Release

@JAndrassy JAndrassy changed the title folder name containing '-' corrupted in makefile folder name starting with 'eclipse-' corrupted in makefile Mar 28, 2020
@jantje
Copy link
Member

jantje commented May 4, 2020

I can not reproduce the issue here
afbeelding

@JAndrassy
Copy link
Author

Eclipse is installed in
/home/duro/eclipse/
and workspace is
/home/duro/eclipse-workspace/
so something matches ${eclipse_home} in /home/duro/eclipse-workspace/ and replaces it to
${eclipse_home}-workspace/
resulting in
/home/duro/eclipse/-workspace/

@jantje
Copy link
Member

jantje commented May 5, 2020

I'll try this specific combination.

Eclipse is installed in XXX/eclipse/
and workspace is  XXX/eclipse-workspace/

Seems like you are on unix.
If I can't reproduce in windows I'll try linux.
IMHO this seems to be a very specific case.

@JAndrassy
Copy link
Author

JAndrassy commented May 5, 2020

Yes I am on Linux.
The location and name of folder eclipse-workspace is default.
I don't know how many people install eclipse in home folder and name it eclipse. The current installer offers a folder named for example java2020-03 in home folder and creates a subfolder named eclipse in it. I deleted the java2020-03 part so I ended up with folder named eclipse. (And I name my Eclipse installation folder always eclipse.)
And it is possible, that the bug could match other variables to other paths too.

@uzi18
Copy link
Contributor

uzi18 commented May 5, 2020

have linux and used almost the same as @JAndrassy dir structure, workspace is in eclipse-workspace or arduino-workspace
but in facts did not created new project for long time, so will try to reproduce

@jantje
Copy link
Member

jantje commented Jun 30, 2020

Tested on linux and windows.
I can't recreate the problem

@jantje jantje added the domain: build The build does not work as the Arduino IDE. label Jun 30, 2020
@jantje
Copy link
Member

jantje commented Jul 7, 2020

Anyone could recreate this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: build The build does not work as the Arduino IDE.
Projects
None yet
Development

No branches or pull requests

3 participants