Skip to content

Commandline define with string is in code replaced as identifier in stead of string #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bascy opened this issue Dec 16, 2018 · 1 comment

Comments

@Bascy
Copy link

Bascy commented Dec 16, 2018

Compiling the ESPmDNS library from arduinoe_esp32 an error occurs where ARDUINO_VARIANT is replaced by its command line definition.

The command line specifies: -DARDUINO_VARIANT="esp32"
the code is the following:

void MDNSResponder::enableArduino(uint16_t port, bool auth){ mdns_txt_item_t arduTxtData[4] = { {(char*)"board" ,(char*)ARDUINO_VARIANT}, {(char*)"tcp_check" ,(char*)"no"}, {(char*)"ssh_upload" ,(char*)"no"}, {(char*)"auth_upload" ,(char*)"no"} };

Because ARDUINO_VARIANT gets replaced with esp32 in stead of "esp32" the compilation fails with "unknown identifier esp32"

@jantje
Copy link
Member

jantje commented Dec 16, 2018

this is a duplicate of #1028
I would love to see esp to fix this by using the workaround I describe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants