Skip to content

Commit 728756d

Browse files
committed
for #272 check the project to be of arduino nature before trying to modify it.
1 parent 6a61844 commit 728756d

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

it.baeyens.arduino.core/src/it/baeyens/arduino/ide/connector/ArduinoGetPreferences.java

+16-4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import org.eclipse.core.filesystem.URIUtil;
1717
import org.eclipse.core.resources.IProject;
1818
import org.eclipse.core.resources.ResourcesPlugin;
19+
import org.eclipse.core.runtime.CoreException;
1920
import org.eclipse.core.runtime.IPath;
2021
import org.eclipse.core.runtime.IProgressMonitor;
2122
import org.eclipse.core.runtime.IStatus;
@@ -70,10 +71,21 @@ private static void generateDumpFiles(IProgressMonitor monitor) {
7071
Set<String> boardsSet = new HashSet<String>();
7172
for (IProject project : projects) {
7273
if (project.isOpen()) {
73-
String boardName = Common.getBuildEnvironmentVariable(project, ArduinoConst.ENV_KEY_JANTJE_BOARD_ID, "");
74-
String PackageName = Common.getBuildEnvironmentVariable(project, ArduinoConst.ENV_KEY_JANTJE_PACKAGE_ID, "");
75-
String ArchitectureName = Common.getBuildEnvironmentVariable(project, ArduinoConst.ENV_KEY_JANTJE_ARCITECTURE_ID, "");
76-
boardsSet.add(PackageName + ":" + ArchitectureName + ":" + boardName);
74+
try {
75+
if (project.hasNature(ArduinoConst.ArduinoNatureID)) {
76+
String boardName = Common.getBuildEnvironmentVariable(project, ArduinoConst.ENV_KEY_JANTJE_BOARD_ID, "");
77+
String PackageName = Common.getBuildEnvironmentVariable(project, ArduinoConst.ENV_KEY_JANTJE_PACKAGE_ID, "");
78+
String ArchitectureName = Common.getBuildEnvironmentVariable(project, ArduinoConst.ENV_KEY_JANTJE_ARCITECTURE_ID, "");
79+
if (boardName.isEmpty() || PackageName.isEmpty() || ArchitectureName.isEmpty()) {
80+
Common.log(new Status(IStatus.WARNING, ArduinoConst.CORE_PLUGIN_ID, "Skipping project \"" + project.getName()
81+
+ "\" due to missin configuration."));
82+
} else {
83+
boardsSet.add(PackageName + ":" + ArchitectureName + ":" + boardName);
84+
}
85+
}
86+
} catch (CoreException e) {
87+
e.printStackTrace();
88+
}
7789
}
7890
}
7991
for (String board : boardsSet) {

0 commit comments

Comments
 (0)