Refactorted and simplified the upload code

Basically I the time I wrote this code I knew even less what I was doing
as I do today.
As there was also some old code that was no longer used I could simplify
the code.
I still think there is a job in a job so it probably still is overly
complicated, but at least it is simpler now

Author: jantje

io.sloeber.core/src/io/sloeber/core/api/SloeberProject.java

@@ -95,6 +95,10 @@ private SloeberProject(IProject project) {
         }
     }
 
+    public IProject getProject() {
+        return myProject;
+    }
+
     /**
      * convenient method to create project
      * 
@@ -1118,7 +1122,7 @@ private IStatus BuildTarget(String targetName) {
      */
     public IStatus upload() {
 
-        Job upLoadJob = UploadSketchWrapper.upload(myProject,
+        Job upLoadJob = UploadSketchWrapper.upload(this,
                 CoreModel.getDefault().getProjectDescription(myProject).getActiveConfiguration());
 
         if (upLoadJob == null)

io.sloeber.core/src/io/sloeber/core/communication/ArduinoSerial.java

@@ -8,14 +8,15 @@
 import java.util.List;
 
 import org.eclipse.cdt.core.settings.model.ICConfigurationDescription;
-import org.eclipse.core.resources.IProject;
+import io.sloeber.core.api.SloeberProject;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
 import org.eclipse.ui.console.MessageConsoleStream;
 
 import io.sloeber.core.api.BoardDescription;
 import io.sloeber.core.api.Serial;
 
+
 public class ArduinoSerial {
 
     private ArduinoSerial() {
@@ -103,8 +104,7 @@ private static String wait_for_com_Port_to_appear(MessageConsoleStream console,
             int newPortsCopySize = newPorts.size();
             if ((newPortsCopy.isEmpty()) && (newPortsCopySize == prefNewPortsCopySize + 1)) {
                 console.println(ArduinoSerial_Comport_Appeared_and_disappeared);
-                console.println(
-                        ArduinoSerial_Comport_reset_took.replace(MS_TAG, Integer.toString(numTries * delayMs)));
+                console.println(ArduinoSerial_Comport_reset_took.replace(MS_TAG, Integer.toString(numTries * delayMs)));
                 return defaultComPort;
             }
             prefNewPortsCopySize = newPortsCopySize;
@@ -144,8 +144,10 @@ private static String wait_for_com_Port_to_appear(MessageConsoleStream console,
      *            The name of the com port to reset
      * @return The com port to upload to
      */
-    public static String makeArduinoUploadready(MessageConsoleStream console, IProject project,
-            ICConfigurationDescription confDesc, BoardDescription boardDescriptor) {
+    public static String makeArduinoUploadready(MessageConsoleStream console, SloeberProject project,
+            ICConfigurationDescription confDesc) {
+
+        BoardDescription boardDescriptor = project.getBoardDescription(confDesc.getName(), true);
         boolean use_1200bps_touch = getBuildEnvironmentVariable(confDesc, ENV_KEY_UPLOAD_USE_1200BPS_TOUCH, FALSE)
                 .equalsIgnoreCase(TRUE);
         boolean bWaitForUploadPort = getBuildEnvironmentVariable(confDesc, ENV_KEY_WAIT_FOR_UPLOAD_PORT, FALSE)