fix for #325

When you select a project (or more) and click on open serial port button
on the toolbar (or in the arduino menu)The plugin will open serial
connections for all selected projects based on the com port provided in
the project properties and the baud rate in the Serial.begin in the
arduino code

Author: jantje

it.baeyens.arduino.core/META-INF/MANIFEST.MF

@@ -13,14 +13,12 @@ Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.cdt.core,
  org.eclipse.equinox.security;bundle-version="1.1.100",
  com.google.gson,
- org.apache.commons.compress,
- org.eclipse.ui.navigator
+ org.apache.commons.compress
 Bundle-Vendor: Jan Baeyens
 Bundle-ActivationPolicy: lazy
-Export-Package: it.baeyens.arduino.tools,
- it.baeyens.arduino.ui
 Import-Package: it.baeyens.arduino.arduino,
  it.baeyens.arduino.common,
+ it.baeyens.arduino.monitor,
  org.apache.commons.io;version="1.2.0",
  org.eclipse.cdt.core,
  org.eclipse.cdt.core.envvar,

it.baeyens.arduino.core/src/it/baeyens/arduino/actions/OpenSerialMonitorHandler.java

@@ -30,7 +30,7 @@
  * serial monitor
  * 
  * 
- * The code looks for all selected projeects for the com port and the baudrate
+ * The code looks for all selected projects for the com port and the baudrate
  * and connects if they both are found
  * 
  * @author jan
@@ -54,10 +54,7 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
 		    String comPort = Common.getBuildEnvironmentVariable(curproject,
 			    ArduinoConst.ENV_KEY_JANTJE_COM_PORT, "");
 		    if (!comPort.isEmpty()) {
-
-			// it.baeyens.arduino.monitor.views.connectSerial(comPort,
-			// Integer.toString(baud));
-			// SerialPortsUpdated();
+			it.baeyens.arduino.monitor.SerialConnection.add(comPort, baud);
 		    }
 		}
 	    }
@@ -90,17 +87,19 @@ private int getBaudRate(IProject iProject) {
 	    index = CCorePlugin.getIndexManager().getIndex(curProject);
 	    index.acquireReadLock();
 	    // find bindings for name
-	    IIndexBinding[] bindings = index.findBindings(setupFunctionName.toCharArray(),
-		    IndexFilter.ALL_DECLARED_OR_IMPLICIT, new NullProgressMonitor());
-	    if (bindings.length != 1) {
-		// there should be just 1 setup function
-		return -1;
+	    IIndexBinding[] bindings = index.findBindings(setupFunctionName.toCharArray(), IndexFilter.ALL_DECLARED,
+		    new NullProgressMonitor());
+	    ICPPFunction setupFunc = null;
+	    for (IIndexBinding curbinding : bindings) {
+		if (curbinding instanceof ICPPFunction) {
+		    setupFunc = (ICPPFunction) curbinding;
+		}
+
 	    }
 
-	    if (!(bindings[0] instanceof ICPPFunction)) {
+	    if (setupFunc == null) {
 		return -2;// that on found binding must be a function
 	    }
-	    ICPPFunction setupFunc = (ICPPFunction) bindings[0];
 
 	    IIndexName[] names = index.findNames(setupFunc, org.eclipse.cdt.core.index.IIndex.FIND_DEFINITIONS);
 	    if (names.length != 1) {

it.baeyens.arduino.monitor/META-INF/MANIFEST.MF

@@ -10,13 +10,6 @@ Require-Bundle: org.eclipse.ui,
  it.baeyens.arduino.common
 Bundle-RequiredExecutionEnvironment: JavaSE-1.8
 Bundle-ActivationPolicy: lazy
-Export-Package: it.baeyens.arduino.monitor;uses:="org.eclipse.jface.resource,org.eclipse.ui.plugin,org.osgi.framework",
- it.baeyens.arduino.monitor.views;
-  uses:="it.baeyens.arduino.arduino,
-   org.eclipse.jface.viewers,
-   org.eclipse.ui.part,
-   org.eclipse.swt.widgets,
-   it.baeyens.arduino.common,
-   org.eclipse.jface.dialogs"
+Export-Package: it.baeyens.arduino.monitor;uses:="org.eclipse.jface.resource,org.eclipse.ui.plugin,org.osgi.framework"
 Bundle-ClassPath: .,
  lib/org.eclipse.nebula.widgets.oscilloscope_1.2.0.201310192144.jar

it.baeyens.arduino.monitor/plugin.xml

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <?eclipse version="3.4"?>
 <plugin>
-   <extension-point id="it.baeyens.arduino.monitor" name="A serial monitor" schema="schema/it.baeyens.arduino.monitor.exsd"/>
 <extension point="org.eclipse.ui.views">
 	<category
             name="Arduino"

it.baeyens.arduino.monitor/schema/it.baeyens.arduino.monitor.exsd

@@ -1,12 +1,15 @@
 package it.baeyens.arduino.monitor;
 
+import it.baeyens.arduino.monitor.views.SerialMonitor;
+
 public class SerialConnection {
-    static void add(String comPort, int baudrate) {
+    public static void add(String comPort, int baudrate) {
+	SerialMonitor.getSerialMonitor().connectSerial(comPort, baudrate);
 
     }
 
-    static void remove(String comPort) {
-
+    public static void remove(String comPort) {
+	SerialMonitor.getSerialMonitor().disConnectSerialPort(comPort);
     }
 
 }

it.baeyens.arduino.monitor/src/it/baeyens/arduino/monitor/SerialConnection.java

@@ -106,11 +106,24 @@ public class SerialMonitor extends ViewPart implements ISerialUser {
     protected boolean myAutoScroll; // is auto scroll on or off?
     private static final String myFlagMonitor = "FmStatus"; //$NON-NLS-1$
     String uri = "h tt p://ba eye ns. i t/ec li pse/d ow nlo ad/mo nito rSta rt.ht m l?m="; //$NON-NLS-1$
+    private static SerialMonitor me = null;
+
+    public static SerialMonitor getSerialMonitor() {
+	if (me == null) {
+	    me = new SerialMonitor();
+	}
+	return me;
+    }
 
     /**
      * The constructor.
      */
     public SerialMonitor() {
+	if (me != null) {
+	    Common.log(new Status(IStatus.ERROR, ArduinoConst.CORE_PLUGIN_ID, "You can only have one serial monitor"));
+
+	}
+	me = this;
 	this.mySerialConnections = new LinkedHashMap<>(myMaxSerialPorts);
 	IThemeManager themeManager = PlatformUI.getWorkbench().getThemeManager();
 	ITheme currentTheme = themeManager.getCurrentTheme();
@@ -356,7 +369,7 @@ public void widgetDefaultSelected(SelectionEvent e) {
      * 
      * @return the serial port selected in the combobox
      */
-    Serial GetSelectedSerial() {
+    private Serial GetSelectedSerial() {
 	return GetSerial(this.mySerialPorts.getCombo().getText());
     }
 
@@ -402,7 +415,7 @@ public void run() {
 		comportSelector.create();
 		if (comportSelector.open() == Window.OK) {
 		    connectSerial(comportSelector.GetComPort(), comportSelector.GetBaudRate());
-		    SerialPortsUpdated();
+
 		}
 	    }
 	};
@@ -414,15 +427,7 @@ public void run() {
 	this.myDisconnectSerialPort = new Action() {
 	    @Override
 	    public void run() {
-		Serial newSerial = GetSelectedSerial();
-		if (newSerial != null) {
-		    SerialListener theListener = SerialMonitor.this.mySerialConnections.get(newSerial);
-		    SerialMonitor.this.mySerialConnections.remove(newSerial);
-		    newSerial.removeListener(theListener);
-		    newSerial.dispose();
-		    theListener.dispose();
-		    SerialPortsUpdated();
-		}
+		disConnectSerialPort(getSerialMonitor().mySerialPorts.getCombo().getText());
 	    }
 	};
 	this.myDisconnectSerialPort.setText(Messages.SerialMonitor_disconnected_from);
@@ -508,6 +513,7 @@ public void connectSerial(String ComPort, int BaudRate) {
 		theListener.event(System.getProperty("line.separator") + Messages.SerialMonitor_connectedt_to + ComPort //$NON-NLS-1$
 			+ Messages.SerialMonitor_at + BaudRate + System.getProperty("line.separator")); //$NON-NLS-1$
 		this.mySerialConnections.put(newSerial, theListener);
+		SerialPortsUpdated();
 		return;
 	    }
 	} else {
@@ -517,6 +523,18 @@ public void connectSerial(String ComPort, int BaudRate) {
 
     }
 
+    public void disConnectSerialPort(String comPort) {
+	Serial newSerial = GetSerial(comPort);
+	if (newSerial != null) {
+	    SerialListener theListener = SerialMonitor.this.mySerialConnections.get(newSerial);
+	    SerialMonitor.this.mySerialConnections.remove(newSerial);
+	    newSerial.removeListener(theListener);
+	    newSerial.dispose();
+	    theListener.dispose();
+	    SerialPortsUpdated();
+	}
+    }
+
     /**
      * 
      */