More fixes for #272

Author: jantje

it.baeyens.arduino.common/src/it/baeyens/arduino/common/ArduinoInstancePreferences.java

@@ -366,7 +366,7 @@ public static long getStoredPreferenceModificatonStamp() {
 	return getGlobalLong(KEY_PREFERENCE_MODIFICATION_STAMP);
     }
 
-    public static void getStoredPreferenceModificatonStamp(long stamp) {
+    public static void setStoredPreferenceModificatonStamp(long stamp) {
 	setGlobalValue(KEY_PREFERENCE_MODIFICATION_STAMP, stamp);
     }
 }

it.baeyens.arduino.core/src/it/baeyens/arduino/ide/connector/ArduinoGetPreferences.java

@@ -31,9 +31,6 @@ public class ArduinoGetPreferences {
      */
     private static boolean arduinoIdeSupportsDumpFiles() {
 	String IDEVersion = ArduinoInstancePreferences.getArduinoIDEVersion();
-	if (IDEVersion.equalsIgnoreCase("nightly")) {
-	    return true;
-	}
 	if (IDEVersion.trim().split("\\.").length != 3)
 	    return false;
 	if (IDEVersion.compareTo("1.6.4") > 0) {
@@ -55,6 +52,16 @@ private static boolean newerBoardsAvailable() {
 	return (preferenceFile.lastModified() != storedPreferenceModificatonStamp);
     }
 
+    private static void storePreferenceModificationStamp() {
+
+	File preferenceFile = Common.getPreferenceFile();
+	ArduinoInstancePreferences.setStoredPreferenceModificatonStamp(preferenceFile.lastModified());
+    }
+
+    private static void emptyPreferenceModificationStamp() {
+	ArduinoInstancePreferences.setStoredPreferenceModificatonStamp(-1);
+    }
+
     /**
      * loops through all the projects and finds all board ID's then for each boardID it will create a arduino ide preference dump file
      */
@@ -133,10 +140,12 @@ public static boolean updateArduinoEnvironmentVariablesForAllProjectsIfNeeded()
 	    if (newerBoardsAvailable()) {
 		deleteAllDumpFiles();
 		generateDumpFiles(null);
+		storePreferenceModificationStamp();
 		return true;
 	    }
 	    return false;
 	}
+	emptyPreferenceModificationStamp();
 	return deleteAllDumpFiles();
 
     }

it.baeyens.arduino.core/src/it/baeyens/arduino/ui/ArduinoPreferencePage.java

@@ -179,6 +179,9 @@ public boolean performOk() {
 	case "1.6.4":
 	    infoMessage = "Arduino IDE " + mArduinoIdeVersion.getStringValue() + " only works with Teensy.";
 	    break;
+	case "1.6.5":
+	    infoMessage = "Arduino IDE " + mArduinoIdeVersion.getStringValue() + " is currently under test.";
+	    break;
 	default:
 	    infoMessage = "You are using a version of the Arduino IDE that is unknow or newer than available at the release of this plugin.";
 	    infoMessage += "\nIf it is a newer version please feed back usage results to Jantje.";
@@ -191,8 +194,10 @@ public boolean performOk() {
 	if (!showError(infoMessage)) {
 	    return false;
 	}
-	ArduinoGetPreferences.updateArduinoEnvironmentVariablesForAllProjectsIfNeeded();
+
 	super.performOk();
+	mArduinoIdeVersion.store();
+	ArduinoGetPreferences.updateArduinoEnvironmentVariablesForAllProjectsIfNeeded();
 	setWorkSpacePathVariables();
 
 	// reset the previous selected values
@@ -326,4 +331,10 @@ private boolean testStatus() {
 	return false;
     }
 
+    @Override
+    protected void performApply() {
+	mIsDirty = true;
+	super.performApply();
+    }
+
 }