Skip to content

Commit 08e0291

Browse files
author
jan
committed
Use UTF-8 as file encoder instead of the default one
1 parent 7e314dc commit 08e0291

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

io.sloeber.autoBuild/src/io/sloeber/autoBuild/helpers/api/AutoBuildConstants.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.sloeber.autoBuild.helpers.api;
22

33
import java.io.File;
4+
import java.nio.charset.Charset;
45

56
import org.eclipse.core.runtime.IPath;
67
import org.eclipse.core.runtime.Path;
@@ -20,6 +21,7 @@ public class AutoBuildConstants {
2021
public static final boolean isWindows = Platform.getOS().equals(Platform.OS_WIN32);
2122
public static final boolean isLinux = Platform.getOS().equals(Platform.OS_LINUX);
2223
public static final boolean isMac = Platform.getOS().equals(Platform.OS_MACOSX);
24+
public static final Charset AUTOBUILD_CONFIG_FILE_CHARSET = Charset.forName("UTF-8");
2325

2426
public static final int PARRALLEL_BUILD_UNLIMITED_JOBS = -1;
2527
public static final int PARRALLEL_BUILD_OPTIMAL_JOBS = -2;

io.sloeber.autoBuild/src/io/sloeber/autoBuild/helpers/api/KeyValueTree.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.util.AbstractMap.SimpleEntry;
66
import java.io.File;
77
import java.io.IOException;
8-
import java.nio.charset.Charset;
98
import java.util.LinkedHashMap;
109
import java.util.Map;
1110
import java.util.Map.Entry;
@@ -212,7 +211,7 @@ public void mergeFile(File boardsFileName) throws IOException {
212211
return;
213212
}
214213

215-
String curConfigsText = FileUtils.readFileToString(boardsFileName, Charset.defaultCharset());
214+
String curConfigsText = FileUtils.readFileToString(boardsFileName, AUTOBUILD_CONFIG_FILE_CHARSET);
216215
String[] lines = curConfigsText.split(NEWLINE);
217216
for (String line : lines) {
218217
if ((line.length() == 0) || (line.charAt(0) == '#'))

io.sloeber.autoBuild/src/io/sloeber/autoBuild/integration/AutoBuildConfigurationDescriptionProvider.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
package io.sloeber.autoBuild.integration;
1616

1717

18+
import static io.sloeber.autoBuild.helpers.api.AutoBuildConstants.*;
1819
import java.io.File;
1920
import java.io.IOException;
2021
import java.nio.charset.Charset;
@@ -43,6 +44,7 @@ public class AutoBuildConfigurationDescriptionProvider extends CConfigurationDat
4344
private static final String AUTO_BUILD_TEAM_FILE = "autoBuildProject.cfg"; //$NON-NLS-1$
4445

4546

47+
4648
// public class KeyValuePairs{
4749
// private String myLinePrefix;
4850
// private String myLineEnd;
@@ -151,7 +153,7 @@ public CConfigurationData applyConfiguration(ICConfigurationDescription cfgDescr
151153
boolean needsWriting = true;
152154
String configText= keyValuePairs.dump();
153155
if (projectFile.exists()) {
154-
String curConfigsText = FileUtils.readFileToString(projectFile, Charset.defaultCharset());
156+
String curConfigsText = FileUtils.readFileToString(projectFile, AUTOBUILD_CONFIG_FILE_CHARSET);
155157
needsWriting = !curConfigsText.equals(configText);
156158
}
157159
if (needsWriting) {

io.sloeber.tests/src/io/sloeber/junit/TxtWorkAroundRegression.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11

22
package io.sloeber.junit;
33

4+
import static io.sloeber.autoBuild.helpers.api.AutoBuildConstants.*;
45
import static io.sloeber.core.txt.WorkAround.*;
56
import static org.junit.Assert.*;
67
import static org.junit.Assume.*;
78

89
import java.io.File;
9-
import java.nio.charset.Charset;
1010
import java.util.Collection;
1111
import java.util.LinkedList;
1212
import org.apache.commons.io.FileUtils;
@@ -81,9 +81,9 @@ public void boardsTxt() throws Exception {
8181
System.out.println("file does not exists " + expectedFile);
8282
assumeFalse(true);// skip the test
8383
}
84-
String input = FileUtils.readFileToString(inputFile, Charset.defaultCharset());
84+
String input = FileUtils.readFileToString(inputFile, AUTOBUILD_CONFIG_FILE_CHARSET);
8585
input = input.replace("\r\n", "\n");
86-
String expected = FileUtils.readFileToString(expectedFile, Charset.defaultCharset());
86+
String expected = FileUtils.readFileToString(expectedFile, AUTOBUILD_CONFIG_FILE_CHARSET);
8787
String actual = boardsApplyWorkArounds(input);
8888
String cleanedExpected = clean(expected);
8989
String cleanedActual = clean(actual);
@@ -108,7 +108,7 @@ public void platformTxt() throws Exception {
108108
System.out.println("file does not exists " + inputFile);
109109
assumeFalse(true);// skip the test
110110
}
111-
String input = FileUtils.readFileToString(inputFile, Charset.defaultCharset());
111+
String input = FileUtils.readFileToString(inputFile, AUTOBUILD_CONFIG_FILE_CHARSET);
112112
input = input.replace("\r\n", "\n");
113113
String currentWorkAround = platformApplyWorkArounds(input, inputFile);
114114
String cleanedCurrentWorkAround = clean(currentWorkAround);
@@ -119,7 +119,7 @@ public void platformTxt() throws Exception {
119119
assumeFalse(true);// skip the test
120120
}
121121

122-
String expected = FileUtils.readFileToString(expectedFile, Charset.defaultCharset());
122+
String expected = FileUtils.readFileToString(expectedFile, AUTOBUILD_CONFIG_FILE_CHARSET);
123123
String cleanedExpected = clean(expected);
124124

125125
if (!cleanedExpected.equals(cleanedCurrentWorkAround)) {
@@ -146,9 +146,9 @@ public void programmerTxt() throws Exception {
146146
System.out.println("file does not exists " + expectedFile);
147147
return;
148148
}
149-
String input = FileUtils.readFileToString(inputFile, Charset.defaultCharset());
149+
String input = FileUtils.readFileToString(inputFile, AUTOBUILD_CONFIG_FILE_CHARSET);
150150
input = input.replace("\r\n", "\n");
151-
String expected = FileUtils.readFileToString(expectedFile, Charset.defaultCharset());
151+
String expected = FileUtils.readFileToString(expectedFile,AUTOBUILD_CONFIG_FILE_CHARSET);
152152
String actual = programmersApplyWorkArounds(input);
153153
String cleanedExpected = clean(expected);
154154
String cleanedActual = clean(actual);

0 commit comments

Comments
 (0)