Skip to content

Commit 67addff

Browse files
Fix issues identified by Psalm
1 parent 9b06768 commit 67addff

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

.psalm/baseline.xml

-12
Original file line numberDiff line numberDiff line change
@@ -203,17 +203,5 @@
203203
<PossiblyUndefinedMethod occurrences="1">
204204
<code>toString</code>
205205
</PossiblyUndefinedMethod>
206-
<RedundantConditionGivenDocblockType occurrences="10">
207-
<code>assert($node-&gt;namespacedName instanceof Name)</code>
208-
<code>assert($node-&gt;namespacedName instanceof Name)</code>
209-
<code>assert($node-&gt;namespacedName instanceof Name)</code>
210-
<code>assert($parentNode-&gt;namespacedName instanceof Name)</code>
211-
<code>assert($parentNode-&gt;namespacedName instanceof Name)</code>
212-
<code>assert(isset($node-&gt;name))</code>
213-
<code>assert(isset($node-&gt;namespacedName))</code>
214-
<code>assert(isset($node-&gt;namespacedName))</code>
215-
<code>assert(isset($parameter-&gt;var-&gt;name))</code>
216-
<code>assert(isset($parentNode-&gt;namespacedName))</code>
217-
</RedundantConditionGivenDocblockType>
218206
</file>
219207
</files>

src/StaticAnalysis/CodeUnitFindingVisitor.php

-8
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,6 @@ private function signature(ClassMethod|Function_ $node): string
132132
$parameters = [];
133133

134134
foreach ($node->getParams() as $parameter) {
135-
assert(isset($parameter->var->name));
136-
137135
$parameterAsString = '';
138136

139137
if ($parameter->type !== null) {
@@ -224,8 +222,6 @@ private function processMethod(ClassMethod $node): void
224222

225223
assert($parentNode instanceof Class_ || $parentNode instanceof Trait_ || $parentNode instanceof Enum_);
226224
assert(isset($parentNode->name));
227-
assert(isset($parentNode->namespacedName));
228-
assert($parentNode->namespacedName instanceof Name);
229225

230226
$parentName = $parentNode->name->toString();
231227
$parentNamespacedName = $parentNode->namespacedName->toString();
@@ -259,10 +255,6 @@ private function processMethod(ClassMethod $node): void
259255

260256
private function processFunction(Function_ $node): void
261257
{
262-
assert(isset($node->name));
263-
assert(isset($node->namespacedName));
264-
assert($node->namespacedName instanceof Name);
265-
266258
$name = $node->name->toString();
267259
$namespacedName = $node->namespacedName->toString();
268260

0 commit comments

Comments
 (0)