Let remote.push return a PushInfoList

List-like, so that it's backward compatible. But it has a new method
raise_on_error, that throws an exception if anything failed to push.

Related to gitpython-developers#621

Author: Sjord

Diff for: git/remote.py

@@ -47,7 +47,7 @@
 log.addHandler(logging.NullHandler())
 
 
-__all__ = ('RemoteProgress', 'PushInfo', 'FetchInfo', 'Remote')
+__all__ = ('RemoteProgress', 'PushInfo', 'PushInfoList', 'FetchInfo', 'Remote')
 
 #{ Utilities
 
@@ -84,6 +84,19 @@ def to_progress_instance(progress):
     return progress
 
 
+class PushInfoList(list):
+    def __init__(self):
+        super().__init__()
+        self.exception = None
+
+    def raise_on_error(self):
+        """
+        Raise an exception if any ref failed to push.
+        """
+        if self.exception:
+            raise self.exception
+
+
 class PushInfo(object):
     """
     Carries information about the result of a push operation of a single head::
@@ -728,7 +741,7 @@ def _get_push_info(self, proc, progress):
         # read the lines manually as it will use carriage returns between the messages
         # to override the previous one. This is why we read the bytes manually
         progress_handler = progress.new_message_handler()
-        output = []
+        output = PushInfoList()
 
         def stdout_handler(line):
             try:
@@ -741,11 +754,12 @@ def stdout_handler(line):
         stderr_text = progress.error_lines and '\n'.join(progress.error_lines) or ''
         try:
             proc.wait(stderr=stderr_text)
-        except Exception:
+        except Exception as e:
             if not output:
                 raise
             elif stderr_text:
-                log.warning("Error lines received while fetching: %s", stderr_text)
+                log.warning("Error lines received while pushing: %s", stderr_text)
+                output.exception = e
 
         return output
 
@@ -843,7 +857,7 @@ def push(self, refspec=None, progress=None, **kwargs):
         :note: No further progress information is returned after push returns.
         :param kwargs: Additional arguments to be passed to git-push
         :return:
-            list(PushInfo, ...) list of PushInfo instances, each
+            PushInfoList list-like of PushInfo instances, each
             one informing about an individual head which had been updated on the remote
             side.
             If the push contains rejected heads, these will have the PushInfo.ERROR bit set