DNSServer: Handle examplewww.com correctly

SimonWilkinson · SimonWilkinson · commit 9ab5ec529763 · 2019-01-04T12:10:22.000Z
Just replacing 'www.' with the empty string when we assign the domainname will remove all occurrences of 'www.', not just those at the start of the string. Change this to a startsWith check so that only "www." at the beginning of the string is removed.
diff --git a/libraries/DNSServer/src/DNSServer.cpp b/libraries/DNSServer/src/DNSServer.cpp
@@ -46,7 +46,8 @@ void DNSServer::stop()
 void DNSServer::downcaseAndRemoveWwwPrefix(String &domainName)
 {
   domainName.toLowerCase();
-  domainName.replace("www.", "");
+  if (domainName.startsWith("www."))
+      domainName.remove(0, 4);
 }
 
 void DNSServer::processNextRequest()

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,8 @@ void DNSServer::stop()`
`46`	`46`	`void DNSServer::downcaseAndRemoveWwwPrefix(String &domainName)`
`47`	`47`	`{`
`48`	`48`	`domainName.toLowerCase();`
`49`		`- domainName.replace("www.", "");`
	`49`	`+ if (domainName.startsWith("www."))`
	`50`	`+ domainName.remove(0, 4);`
`50`	`51`	`}`
`51`	`52`
`52`	`53`	`void DNSServer::processNextRequest()`