Skip to content

Commit 4ec704c

Browse files
author
MomIsBestFriend
committed
Made the code check "ID" to be more verbose
as @datapythonista suggested in pandas-dev#30755 (comment)
1 parent f611e26 commit 4ec704c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

ci/code_checks.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ if [[ -z "$CHECK" || "$CHECK" == "lint" ]]; then
102102

103103
MSG='Check for use of not concatenated strings' ; echo $MSG
104104
if [[ "$GITHUB_ACTIONS" == "true" ]]; then
105-
$BASE_DIR/scripts/validate_string_concatenation --id="STC" --format="[error]{source_path}:{line_number}:{msg}" .
105+
$BASE_DIR/scripts/validate_string_concatenation --id="strings_to_concatenate" --format="[error]{source_path}:{line_number}:{msg}" .
106106
else
107-
$BASE_DIR/scripts/validate_string_concatenation --id="STC" .
107+
$BASE_DIR/scripts/validate_string_concatenation --id="strings_to_concatenate" .
108108
fi
109109
RET=$(($RET + $?)) ; echo $MSG "DONE"
110110

scripts/validate_string_concatenation.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,9 @@ def bare_pytest_raises(source_path: str) -> Generator[Tuple[str, int, str], None
231231

232232
if __name__ == "__main__":
233233
FUNCTIONS_MAP = {
234-
"STC": strings_to_concatenate,
235-
"SWWPS": strings_with_wrong_placed_space,
236-
"BPR": bare_pytest_raises,
234+
"strings_to_concatenate": strings_to_concatenate,
235+
"strings_with_wrong_placed_space": strings_with_wrong_placed_space,
236+
"bare_pytest_raises": bare_pytest_raises,
237237
}
238238

239239
parser = argparse.ArgumentParser(description="Unwanted patterns checker.")

0 commit comments

Comments
 (0)