Skip to content

Commit 943cb33

Browse files
som-snyttjoroKr21
andcommitted
Restore ImmutableKeySet test
Co-authored-by: Georgi Krastev <[email protected]>
1 parent a222b9b commit 943cb33

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/library/scala/collection/immutable/Map.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ trait MapOps[K, +V, +CC[X, +Y] <: MapOps[X, Y, CC, _], +C <: MapOps[K, V, CC, C]
142142
override def keySet: Set[K] = new ImmutableKeySet
143143

144144
/** The implementation class of the set returned by `keySet` */
145-
protected class ImmutableKeySet extends AbstractSet[K] with GenKeySet with DefaultSerializable {
145+
protected[immutable] class ImmutableKeySet extends AbstractSet[K] with GenKeySet with DefaultSerializable {
146146
def incl(elem: K): Set[K] = if (this(elem)) this else empty ++ this + elem
147147
def excl(elem: K): Set[K] = if (this(elem)) empty ++ this - elem else this
148148
}

src/library/scala/collection/immutable/Set.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ object Set extends IterableFactory[Set] {
106106
case s: Set2[E] => s
107107
case s: Set3[E] => s
108108
case s: Set4[E] => s
109-
//case s: MapOps[E @unchecked, _, _, _]#ImmutableKeySet => s
110109
case s: HashMap[E @unchecked, _]#HashKeySet => s
110+
case s: MapOps[E, Any, Map, Map[E, Any]]#ImmutableKeySet @unchecked => s
111111
// We also want `SortedSet` (and subclasses, such as `BitSet`)
112112
// to rebuild themselves, to avoid element type widening issues.
113113
case _ => newBuilder[E].addAll(it).result()

test/junit/scala/collection/FactoriesTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ class FactoriesTest {
203203
im.Set(1),
204204
im.HashSet("a", "b", "c"),
205205
im.ListSet('c', 'd'),
206-
//im.Map("a" -> 1, "b" -> 1, "c" -> 1).keySet, // MapOps$ImmutableKeySet
206+
im.Map("a" -> 1, "b" -> 1, "c" -> 1).keySet, // MapOps$ImmutableKeySet
207207
im.HashMap("a" -> 1, "b" -> 1, "c" -> 1).keySet, // HashKeySet
208208
)
209209

test/junit/scala/collection/immutable/SetTest.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ class SetTest {
7373
assertEquals(WeekDay.values, valuesa)
7474

7575
// Make sure regular Map keySets do not rebuild themselves on widening with toSet
76-
//val mapset = Map(1 -> "cod", 2 -> "herring").keySet
77-
//val mapseta = any(mapset)
78-
//assertSame(mapset, mapseta) // WIP see Set.from
76+
val mapset = Map(1 -> "cod", 2 -> "herring").keySet
77+
val mapseta = any(mapset)
78+
assertSame(mapset, mapseta) // WIP see Set.from
7979
}
8080

8181
@deprecated("Uses deprecated API", since="2.13")

0 commit comments

Comments
 (0)