Skip to content
This repository was archived by the owner on Nov 20, 2020. It is now read-only.

Commit b2be180

Browse files
Lucme-no-dev
Luc
authored andcommitted
Clean warnings when all warning enabled (#2112)
* Clean warnings when all warning enabled Not used variables / functions due to debug log Dual define with different values : cores\esp32/binary.h #define B110 6 #define B1000000 64 tools/sdk/include/newlib/sys/termios.h #define B110 3 #define B1000000 23 Local variable returned in WiFiclient Secure * change due to deprecated function * Update with proper variable and label * Update esp32-hal-i2c.c * Apply changes requested * Fix warnings due to #define conflict thanks @atanisoft
1 parent 4d701b2 commit b2be180

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/WiFiClientSecure.cpp

+8-7
Original file line numberDiff line numberDiff line change
@@ -232,18 +232,19 @@ bool WiFiClientSecure::verify(const char* fp, const char* domain_name)
232232
}
233233

234234
char *WiFiClientSecure::_streamLoad(Stream& stream, size_t size) {
235-
char *dest = (char*)malloc(size);
235+
static char *dest = nullptr;
236+
if(dest) {
237+
free(dest);
238+
}
239+
dest = (char*)malloc(size);
236240
if (!dest) {
237241
return nullptr;
238242
}
239243
if (size != stream.readBytes(dest, size)) {
240244
free(dest);
241-
return nullptr;
245+
dest = nullptr;
242246
}
243-
char ret[size+1];
244-
snprintf(ret, size, "%s", dest);
245-
free(dest);
246-
return ret;
247+
return dest;
247248
}
248249

249250
bool WiFiClientSecure::loadCACert(Stream& stream, size_t size) {
@@ -290,4 +291,4 @@ int WiFiClientSecure::lastError(char *buf, const size_t size)
290291
void WiFiClientSecure::setHandshakeTimeout(unsigned long handshake_timeout)
291292
{
292293
sslclient->handshake_timeout = handshake_timeout * 1000;
293-
}
294+
}

0 commit comments

Comments
 (0)