Print number of warnings in the CLI (#184)

Author: tommy-mitchell

source/lib/formatter.ts

@@ -50,7 +50,12 @@ export default (diagnostics: Diagnostic[], showDiff = false): string => {
 			}
 		}
 
-		entry.errorCount++;
+		if (diagnostic.severity === 'error') {
+			entry.errorCount++;
+		} else if (diagnostic.severity === 'warning') {
+			entry.warningCount++;
+		}
+
 		entry.messages.push(diagnostic);
 	}
 

source/test/cli.ts

@@ -163,3 +163,31 @@ test('exported formatter matches cli results', async t => {
 		'1 error',
 	]);
 });
+
+test('warnings are reported correctly and do not fail', async t => {
+	const {exitCode, stdout} = await execa('../../../../cli.js', {
+		cwd: path.join(__dirname, 'fixtures/warnings/only-warnings'),
+	});
+
+	t.is(exitCode, 0);
+	verifyCli(t, stdout, [
+		'⚠  4:0  Type for expression one(1, 1) is: number',
+		'',
+		'1 warning',
+	]);
+});
+
+test('warnings are reported with errors', async t => {
+	const {exitCode, stderr} = await t.throwsAsync<ExecaError>(execa('../../../../cli.js', {
+		cwd: path.join(__dirname, 'fixtures/warnings/with-errors'),
+	}));
+
+	t.is(exitCode, 1);
+	verifyCli(t, stderr, [
+		'✖  5:19  Argument of type number is not assignable to parameter of type string.',
+		'⚠  4:0   Type for expression one(1, 1) is: number',
+		'',
+		'1 warning',
+		'1 error',
+	]);
+});

source/test/fixtures/warnings/only-warnings/index.d.ts

@@ -0,0 +1,6 @@
+declare const one: {
+	(foo: string, bar: string): string;
+	(foo: number, bar: number): number;
+};
+
+export default one;

source/test/fixtures/warnings/only-warnings/index.js

@@ -0,0 +1,3 @@
+module.exports.default = (foo, bar) => {
+	return foo + bar;
+};

source/test/fixtures/warnings/only-warnings/index.test-d.ts

@@ -0,0 +1,4 @@
+import {printType} from '../../../..';
+import one from '.';
+
+printType(one(1, 1));

source/test/fixtures/warnings/only-warnings/package.json

@@ -0,0 +1,3 @@
+{
+	"name": "foo"
+}

source/test/fixtures/warnings/with-errors/index.d.ts

@@ -0,0 +1,6 @@
+declare const one: {
+	(foo: string, bar: string): string;
+	(foo: number, bar: number): number;
+};
+
+export default one;

source/test/fixtures/warnings/with-errors/index.js

@@ -0,0 +1,3 @@
+module.exports.default = (foo, bar) => {
+	return foo + bar;
+};

source/test/fixtures/warnings/with-errors/index.test-d.ts

@@ -0,0 +1,5 @@
+import {printType, expectType} from '../../../..';
+import one from '.';
+
+printType(one(1, 1));
+expectType<string>(one(1, 2));

source/test/fixtures/warnings/with-errors/package.json

@@ -0,0 +1,3 @@
+{
+	"name": "foo"
+}