You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After upgrading to @ui5/webcomponents-react 2.10.0, we noticed that the loading indicator we render via the NoDataComponent inside the <AnalyticalTable /> is no longer visible. It appears that a new <div> "AnalyticalTableNoDataContainer" was introduced around the NoDataComponent, and it comes with a fixed height style based on the table body. However, during loading:
The table has no data.
We set minRows={1}, which makes the table body height quite small.
Our custom NoDataComponent has a greater height than the table body at this point, causing the loading indicator to be clipped
Temporary Fix:
To make it visible again, we had to override the AnalyticalTableNoDataContainer height using height: 100% !important which is not ideal
1- Render the <AnalyticalTable /> component with minRows={1}.
2- Provide a custom NoDataComponent with content higher than a single row height (e.g. 200px).
3- Trigger the loading state
4- Observe that the content inside the NoDataComponent is clipped due to the fixed height of the surrounding wrapper
Expected Behaviour
Loading indicator should be visible
Screenshots or Videos
No response
UI5 Web Components for React Version
2.10.0
UI5 Web Components Version
2.10.0
Browser
Chrome
Operating System
No response
Additional Context
No response
Relevant log output
Organization
No response
Declaration
I’m not disclosing any internal or sensitive information.
The text was updated successfully, but these errors were encountered:
This change was made due to an accessibility issue.
To prevent UI elements from jumping, we assumed the placeholder should always have the same height as the table defined by its minRows.
Also, the prop is intended solely for no-data placeholders (such as an IllustratedMessage), not for loading indicators—partly to ensure accessibility.
That said, you can still increase the size of the placeholder without overriding styles by adjusting the minRows during loading. Here’s an example demonstrating this approach. Would that work for you?
Additionally, we’ll clarify which component is expected for NoDataComponent in this PR.
Describe the bug
After upgrading to @ui5/webcomponents-react 2.10.0, we noticed that the loading indicator we render via the
NoDataComponent
inside the<AnalyticalTable />
is no longer visible. It appears that a new<div>
"AnalyticalTableNoDataContainer" was introduced around theNoDataComponent
, and it comes with a fixed height style based on the table body. However, during loading:minRows={1}
, which makes the table body height quite small.NoDataComponent
has a greater height than the table body at this point, causing the loading indicator to be clippedTemporary Fix:
To make it visible again, we had to override the
AnalyticalTableNoDataContainer
height usingheight: 100% !important
which is not idealIsolated Example
https://stackblitz.com/edit/github-57uefeze?file=src%2Fmain.tsx
Reproduction steps
1- Render the
<AnalyticalTable />
component withminRows={1}
.2- Provide a custom
NoDataComponent
with content higher than a single row height (e.g. 200px).3- Trigger the loading state
4- Observe that the content inside the NoDataComponent is clipped due to the fixed height of the surrounding wrapper
Expected Behaviour
Loading indicator should be visible
Screenshots or Videos
No response
UI5 Web Components for React Version
2.10.0
UI5 Web Components Version
2.10.0
Browser
Chrome
Operating System
No response
Additional Context
No response
Relevant log output
Organization
No response
Declaration
The text was updated successfully, but these errors were encountered: