Skip to content

AnalyticalTable: Div AnalyticalTableNoDataContainer has fixed height style which breaks NoDataComponent layout #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
clevianerebeca-silva opened this issue Jun 2, 2025 · 1 comment

Comments

@clevianerebeca-silva
Copy link

Describe the bug

After upgrading to @ui5/webcomponents-react 2.10.0, we noticed that the loading indicator we render via the NoDataComponent inside the <AnalyticalTable /> is no longer visible. It appears that a new <div> "AnalyticalTableNoDataContainer" was introduced around the NoDataComponent, and it comes with a fixed height style based on the table body. However, during loading:

  • The table has no data.
  • We set minRows={1}, which makes the table body height quite small.
  • Our custom NoDataComponent has a greater height than the table body at this point, causing the loading indicator to be clipped

Temporary Fix:
To make it visible again, we had to override the AnalyticalTableNoDataContainer height using height: 100% !important which is not ideal

Isolated Example

https://stackblitz.com/edit/github-57uefeze?file=src%2Fmain.tsx

Reproduction steps

1- Render the <AnalyticalTable /> component with minRows={1}.
2- Provide a custom NoDataComponent with content higher than a single row height (e.g. 200px).
3- Trigger the loading state
4- Observe that the content inside the NoDataComponent is clipped due to the fixed height of the surrounding wrapper

Expected Behaviour

Loading indicator should be visible

Screenshots or Videos

No response

UI5 Web Components for React Version

2.10.0

UI5 Web Components Version

2.10.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Jun 2, 2025

Hi @clevianerebeca-silva

This change was made due to an accessibility issue.
To prevent UI elements from jumping, we assumed the placeholder should always have the same height as the table defined by its minRows.

Also, the prop is intended solely for no-data placeholders (such as an IllustratedMessage), not for loading indicators—partly to ensure accessibility.

That said, you can still increase the size of the placeholder without overriding styles by adjusting the minRows during loading. Here’s an example demonstrating this approach. Would that work for you?

Additionally, we’ll clarify which component is expected for NoDataComponent in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants