Skip to content

Commit 394f33f

Browse files
committed
Merge tag 'tty-6.11-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
Pull tty / serial fixes from Greg KH: "Here are some small tty and serial driver fixes for 6.11-rc4 to resolve some reported problems. Included in here are: - conmakehash.c userspace build issues - fsl_lpuart driver fix - 8250_omap revert for reported regression - atmel_serial rts flag fix All of these have been in linux-next this week with no reported issues" * tag 'tty-6.11-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: Revert "serial: 8250_omap: Set the console genpd always on if no console suspend" tty: atmel_serial: use the correct RTS flag. tty: vt: conmakehash: remove non-portable code printing comment header tty: serial: fsl_lpuart: mark last busy before uart_add_one_port
2 parents 3d9061d + 0863bff commit 394f33f

File tree

4 files changed

+9
-39
lines changed

4 files changed

+9
-39
lines changed

drivers/tty/serial/8250/8250_omap.c

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
#include <linux/pm_wakeirq.h>
2828
#include <linux/dma-mapping.h>
2929
#include <linux/sys_soc.h>
30-
#include <linux/pm_domain.h>
3130

3231
#include "8250.h"
3332

@@ -119,12 +118,6 @@
119118
#define UART_OMAP_TO_L 0x26
120119
#define UART_OMAP_TO_H 0x27
121120

122-
/*
123-
* Copy of the genpd flags for the console.
124-
* Only used if console suspend is disabled
125-
*/
126-
static unsigned int genpd_flags_console;
127-
128121
struct omap8250_priv {
129122
void __iomem *membase;
130123
int line;
@@ -1655,7 +1648,6 @@ static int omap8250_suspend(struct device *dev)
16551648
{
16561649
struct omap8250_priv *priv = dev_get_drvdata(dev);
16571650
struct uart_8250_port *up = serial8250_get_port(priv->line);
1658-
struct generic_pm_domain *genpd = pd_to_genpd(dev->pm_domain);
16591651
int err = 0;
16601652

16611653
serial8250_suspend_port(priv->line);
@@ -1666,19 +1658,8 @@ static int omap8250_suspend(struct device *dev)
16661658
if (!device_may_wakeup(dev))
16671659
priv->wer = 0;
16681660
serial_out(up, UART_OMAP_WER, priv->wer);
1669-
if (uart_console(&up->port)) {
1670-
if (console_suspend_enabled)
1671-
err = pm_runtime_force_suspend(dev);
1672-
else {
1673-
/*
1674-
* The pd shall not be powered-off (no console suspend).
1675-
* Make copy of genpd flags before to set it always on.
1676-
* The original value is restored during the resume.
1677-
*/
1678-
genpd_flags_console = genpd->flags;
1679-
genpd->flags |= GENPD_FLAG_ALWAYS_ON;
1680-
}
1681-
}
1661+
if (uart_console(&up->port) && console_suspend_enabled)
1662+
err = pm_runtime_force_suspend(dev);
16821663
flush_work(&priv->qos_work);
16831664

16841665
return err;
@@ -1688,16 +1669,12 @@ static int omap8250_resume(struct device *dev)
16881669
{
16891670
struct omap8250_priv *priv = dev_get_drvdata(dev);
16901671
struct uart_8250_port *up = serial8250_get_port(priv->line);
1691-
struct generic_pm_domain *genpd = pd_to_genpd(dev->pm_domain);
16921672
int err;
16931673

16941674
if (uart_console(&up->port) && console_suspend_enabled) {
1695-
if (console_suspend_enabled) {
1696-
err = pm_runtime_force_resume(dev);
1697-
if (err)
1698-
return err;
1699-
} else
1700-
genpd->flags = genpd_flags_console;
1675+
err = pm_runtime_force_resume(dev);
1676+
if (err)
1677+
return err;
17011678
}
17021679

17031680
serial8250_resume_port(priv->line);

drivers/tty/serial/atmel_serial.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2514,7 +2514,7 @@ static const struct uart_ops atmel_pops = {
25142514
};
25152515

25162516
static const struct serial_rs485 atmel_rs485_supported = {
2517-
.flags = SER_RS485_ENABLED | SER_RS485_RTS_AFTER_SEND | SER_RS485_RX_DURING_TX,
2517+
.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RX_DURING_TX,
25182518
.delay_rts_before_send = 1,
25192519
.delay_rts_after_send = 1,
25202520
};

drivers/tty/serial/fsl_lpuart.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2923,6 +2923,7 @@ static int lpuart_probe(struct platform_device *pdev)
29232923
pm_runtime_set_autosuspend_delay(&pdev->dev, UART_AUTOSUSPEND_TIMEOUT);
29242924
pm_runtime_set_active(&pdev->dev);
29252925
pm_runtime_enable(&pdev->dev);
2926+
pm_runtime_mark_last_busy(&pdev->dev);
29262927

29272928
ret = lpuart_global_reset(sport);
29282929
if (ret)

drivers/tty/vt/conmakehash.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
* Copyright (C) 1995-1997 H. Peter Anvin
1212
*/
1313

14-
#include <libgen.h>
15-
#include <linux/limits.h>
1614
#include <stdio.h>
1715
#include <stdlib.h>
1816
#include <sysexits.h>
@@ -79,7 +77,6 @@ int main(int argc, char *argv[])
7977
{
8078
FILE *ctbl;
8179
const char *tblname;
82-
char base_tblname[PATH_MAX];
8380
char buffer[65536];
8481
int fontlen;
8582
int i, nuni, nent;
@@ -245,20 +242,15 @@ int main(int argc, char *argv[])
245242
for ( i = 0 ; i < fontlen ; i++ )
246243
nuni += unicount[i];
247244

248-
strncpy(base_tblname, tblname, PATH_MAX);
249-
base_tblname[PATH_MAX - 1] = 0;
250245
printf("\
251246
/*\n\
252-
* Do not edit this file; it was automatically generated by\n\
253-
*\n\
254-
* conmakehash %s > [this file]\n\
255-
*\n\
247+
* Automatically generated file; Do not edit.\n\
256248
*/\n\
257249
\n\
258250
#include <linux/types.h>\n\
259251
\n\
260252
u8 dfont_unicount[%d] = \n\
261-
{\n\t", basename(base_tblname), fontlen);
253+
{\n\t", fontlen);
262254

263255
for ( i = 0 ; i < fontlen ; i++ )
264256
{

0 commit comments

Comments
 (0)