Updated to support net7.0, and latest buildalyzer (#809)

Author: david-driscoll

.build/.build.csproj

@@ -15,10 +15,6 @@
         <PackageReference Include="ReportGenerator" ExcludeAssets="All" />
         <PackageReference Include="JetBrains.ReSharper.GlobalTools" ExcludeAssets="All" />
         <ProjectReference Include="../src/Nuke/Rocket.Surgery.Nuke.csproj" />
-        <PackageReference Include="Microsoft.Build" />
-        <PackageReference Include="Microsoft.Build.Framework" />
-        <PackageReference Include="Microsoft.Build.Tasks.Core" />
-        <PackageReference Include="Microsoft.Build.Utilities.Core" />
     </ItemGroup>
 
     <ItemGroup>

.build/Build.CI.cs

@@ -68,7 +68,7 @@ public static RocketSurgeonGitHubActionsConfiguration CiMiddleware(RocketSurgeon
            .AddNugetPublish()
            .Jobs.OfType<RocketSurgeonsGithubActionsJob>()
            .First(z => z.Name == "Build")
-           .UseDotNetSdks("3.1", "6.0")
+           .UseDotNetSdks("6.0", "7.0")
            .AddNuGetCache()
             // .ConfigureForGitVersion()
            .ConfigureStep<CheckoutStep>(step => step.FetchDepth = 0)

.build/Build.cs

@@ -10,7 +10,6 @@
 using Rocket.Surgery.Nuke.DotNetCore;
 
 [PublicAPI]
-[CheckBuildProjectConfigurations]
 [UnsetVisualStudioEnvironmentVariables]
 [PackageIcon("https://raw.githubusercontent.com/RocketSurgeonsGuild/graphics/master/png/social-square-thrust-rounded.png")]
 [EnsureGitHooks(GitHook.PreCommit)]

.github/workflows/ci.yml

@@ -90,14 +90,14 @@ jobs:
           key: "${{ runner.os }}-nuget-${{ hashFiles('**/Directory.Packages.props') }}-${{ hashFiles('**/Directory.Packages.support.props') }}"
           restore-keys: |
             ${{ runner.os }}-nuget-
-      - name: 🔨 Use .NET Core 3.1 SDK
-        uses: actions/[email protected]
-        with:
-          dotnet-version: '3.1.x'
       - name: 🔨 Use .NET Core 6.0 SDK
         uses: actions/[email protected]
         with:
           dotnet-version: '6.0.x'
+      - name: 🔨 Use .NET Core 7.0 SDK
+        uses: actions/[email protected]
+        with:
+          dotnet-version: '7.0.x'
       - name: 🎁 dotnet tool restore
         run: |
           dotnet tool restore

Directory.Packages.props

@@ -25,16 +25,10 @@
     <PackageVersion Include="ReportGenerator" Version="5.1.12" />
     <PackageVersion Include="YamlDotNet" Version="12.2.1" />
     <PackageVersion Include="JetBrains.ReSharper.GlobalTools" Version="2022.3.0" />
-      <!--        <PackageVersion Include="JetBrains.ReSharper.GlobalTools" Version="2020.3.0-eap05"/>-->
-      <PackageVersion Include="Microsoft.Build" Version="17.4.0" />
-    <PackageVersion Include="Microsoft.Build.Framework" Version="17.4.0" />
-    <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.4.0" />
-    <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.4.0" />
     <PackageVersion Include="LiquidTestReports.Core" Version="1.3.2-beta" />
     <PackageVersion Include="System.Collections.Immutable" Version="6.0.0" />
     <PackageVersion Include="System.Interactive" Version="6.0.1" />
     <PackageVersion Include="System.Interactive.Async" Version="6.0.1" />
-
   </ItemGroup>
   <ItemGroup>
     <PackageVersion Include="Bogus" Version="34.0.2" />

src/Nuke/Extensions.cs

@@ -1,5 +1,6 @@
 namespace Rocket.Surgery.Nuke;
 
+#pragma warning disable CA1724
 /// <summary>
 ///     Extension methods for working with nuke build tasks
 /// </summary>

src/Nuke/Helpers.cs

@@ -1,7 +1,16 @@
 namespace Rocket.Surgery.Nuke;
 
+#pragma warning disable CA1724
+/// <summary>
+///     Helpers for Nuke builds
+/// </summary>
 public static class Helpers
 {
+    /// <summary>
+    ///     Determine if a dotnet tool is installed in the dotnet-tools.json
+    /// </summary>
+    /// <param name="nugetPackageName"></param>
+    /// <returns></returns>
     public static bool IsDotnetToolInstalled(string nugetPackageName)
     {
         var dotnetTools = Path.Combine(NukeBuild.RootDirectory, ".config/dotnet-tools.json");

src/Nuke/Rocket.Surgery.Nuke.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp3.1;net6.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
     <NoWarn>$(NoWarn);CS0436</NoWarn>
       <!-- This has to be turned on because in Nuke.Common.props it is turned off to false, which causes build failures when writing to the same dll multiple times with cross targeting -->
       <AppendTargetFrameworkToOutputPath>true</AppendTargetFrameworkToOutputPath>
@@ -11,11 +11,7 @@
     <PackageReference Include="YamlDotNet" />
     <PackageReference Include="Buildalyzer" />
     <PackageReference Include="Humanizer.Core" />
-    <PackageReference Include="Microsoft.Build" />
-    <PackageReference Include="Microsoft.Build.Framework" />
-    <PackageReference Include="Microsoft.Build.Tasks.Core" />
-    <PackageReference Include="Microsoft.Build.Utilities.Core" />
-      <PackageReference Include="LiquidTestReports.Core" />
+    <PackageReference Include="LiquidTestReports.Core" />
   </ItemGroup>
   <ItemGroup>
     <None Include="build/*.*" Pack="true" PackagePath="build" />

test/Nuke.Tests/Rocket.Surgery.Nuke.Tests.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
-        <TargetFrameworks>netcoreapp3.1;net6.0</TargetFrameworks>
+        <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
     </PropertyGroup>
     <ItemGroup>
         <ProjectReference Include="..\..\src\Nuke\Rocket.Surgery.Nuke.csproj" />