Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit c299876

Browse files
committed
Drop the distinctUntilChanged()
This doesn't actually seem to suppress duplicate events at the moment. I'm guessing it's because it uses '===' comparison and the new event coming through is a different object, even if it looks the same. At any rate, duplicates should get caught by the debounce if they are fired at the same time. If the user reselects the same filter value, it might trigger the source to reload, which isn't ideal, but that's something we can look into later.
1 parent f4c45a9 commit c299876

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

source/components/cardContainer/dataSources/smartDataSource/smartDataActions.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ export function toFilterChanges(filters$: Observable<IFilter<any, any>[]>): Obse
6868
.map(typeAndValues => reduce(typeAndValues, (dictionary, typeAndValue) => {
6969
dictionary[typeAndValue.type] = typeAndValue.value;
7070
return dictionary;
71-
}, {}))
72-
.distinctUntilChanged();
71+
}, {}));
7372
}
7473

7574
export function toTypesWithValues(filters$: Observable<IFilter<any, any>[]>): Observable<ITypeWithValue[]> {

0 commit comments

Comments
 (0)