Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 8b51947

Browse files
author
Josh Graber
committed
Merge pull request #75 from RenovoSolutions/attachment_message_log
MessageLog: use strong types instead of strings
2 parents 498b83b + 6917815 commit 8b51947

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

source/components/messageLog/editableMessageLog.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class EditableMessageLogController {
5555
this.savingMessage = true;
5656
var message: string = this.newMessage;
5757
this.newMessage = '';
58-
return this.messageLogService.addMessage(message);
58+
return this.messageLogService.addMessage({ message: message });
5959
}
6060
}
6161

source/components/messageLog/messageLog.service.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ export var factoryName: string = 'messageLog';
99
export var defaultPageSize: number = 10;
1010

1111
export interface IMessage {
12+
id?: number;
1213
message: string;
13-
createdBy: string,
14-
createdDate: string,
15-
createdTime: string,
14+
createdBy?: string,
15+
createdDate?: Date,
1616
}
1717

1818
export interface IGetMessagesResult {
@@ -21,12 +21,12 @@ export interface IGetMessagesResult {
2121
}
2222

2323
export interface IMessageLogDataService {
24-
saveMessage(message: string): ng.IPromise<void>;
24+
saveMessage(message: IMessage): ng.IPromise<void>;
2525
getMessages(startFrom: number, quantity: number): ng.IPromise<IGetMessagesResult>;
2626
}
2727

2828
export interface IMessageLog {
29-
addMessage(message: string): ng.IPromise<void>;
29+
addMessage(message: IMessage): ng.IPromise<void>;
3030
visibleMessages: IMessage[];
3131

3232
getNextPage(): ng.IPromise<void>;
@@ -85,7 +85,7 @@ export class MessageLog {
8585
}
8686
/* tslint:enable */
8787

88-
addMessage(message: string): ng.IPromise<void> {
88+
addMessage(message: IMessage): ng.IPromise<void> {
8989
return this.dataService.saveMessage(message).then((): void => {
9090
this.getTopPage();
9191
});

0 commit comments

Comments
 (0)