some fixes

Author: sjpotter

BUILD_TEST.md

@@ -0,0 +1,20 @@
+# Building gesher
+
+docker build -t quay.io/spotter/gesher:test -f Dockerfile .
+docker push quay.io/spotter/gesher:test
+
+one would need to modify the tag and the integration test to use the proper image
+
+# Building admission-test admisson controller
+
+docker build -t quay.io/spotter/gesher-admisison-test:test -f Dockerfile.admission-test .
+docker push quay.io/spotter/gesher-admisison-test:test
+
+one would need to modify the tag and the integration test to use the proper image
+
+# Building and running integration tests
+
+docker build -t quay.io/spotter/gesher-integration-test:test -f Dockerfile.integration-test .
+
+docker run -it --rm -v ~/.kube/config:/kubeconfig -e KUBECONFIG=/kubeconfig quay.io/spotter/gesher-integration-test:test ginkgo -v integration-tests/...
+

pkg/controller/proxyvalidatingtype/data.go

@@ -13,6 +13,7 @@ import (
 
 var (
 	proxyTypeData = &ProxyTypeData{}
+	caBundle      []byte
 )
 
 type typeInstanceMap map[types.UID]bool
@@ -241,6 +242,6 @@ func selfConfig() v1beta1.WebhookClientConfig {
 			Name:      "test",
 			Path:      &path,
 		},
-		CABundle: nil,
+		CABundle: caBundle,
 	}
 }

pkg/controller/proxyvalidatingtype/proxyvalidatingtype_controller.go

@@ -24,7 +24,7 @@ var log = logf.Log.WithName("controller_proxyvalidatingtype")
 func Add(mgr manager.Manager) error {
 	var err error
 
-	_, err = ioutil.ReadFile(filepath.Join(common.CertDir, common.CertPem))
+	caBundle, err = ioutil.ReadFile(filepath.Join(common.CertDir, common.CertPem))
 	if err != nil {
 		return err
 	}