Skip to content

[jupyterbook-latex] [re_with_feedback] problematic math outputs generated by code #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shlff opened this issue Feb 10, 2021 · 6 comments · Fixed by #247
Closed

[jupyterbook-latex] [re_with_feedback] problematic math outputs generated by code #95

shlff opened this issue Feb 10, 2021 · 6 comments · Fixed by #247

Comments

@shlff
Copy link
Member

shlff commented Feb 10, 2021

Hi @AakashGfude and @mmcky , I find that in lecture re_with_feedback,

  • some outputs (especially numbers) generated by code look a bit weird,
  • some outputs (especially math expressions) are mistakenly printed.

Please see the screenshot of strange number outputs (left: PDFs generated by rst, right: PDFs generated by myst):

Screen Shot 2021-02-11 at 8 24 21 am

Please see the screenshot of wrong math outputs (left: PDFs generated by rst, right: PDFs generated by myst):

Screen Shot 2021-02-11 at 8 25 54 am

and

Screen Shot 2021-02-11 at 8 28 15 am

@shlff shlff changed the title [jupyterbook-latex] [re_with_feedback] [jupyterbook-latex] [re_with_feedback] problematic math outputs generated by code Feb 10, 2021
@mmcky
Copy link
Contributor

mmcky commented Feb 15, 2021

thanks @shlff this does need improvement.

the second case with misaligned outputs is concerning. So I have tagged this as high-priority for review

@mmcky
Copy link
Contributor

mmcky commented Feb 16, 2021

@AakashGfude in d6fb77c I have updated the priority for pure latex output which may help this issue.

@mmcky
Copy link
Contributor

mmcky commented Feb 18, 2021

@AakashGfude When you get a chance would you mind to regenerate the pdf after the last iteration on jupyter-book/jupyter-book#1167 to see if this is fixed from the reordering

@AakashGfude
Copy link
Member

Thanks @mmcky , using your PR in myst-nb executablebooks/MyST-NB#305, the output seems to be rendering nicely.

Screen Shot 2021-03-01 at 3 34 48 pm

Screen Shot 2021-03-01 at 3 36 00 pm

@mmcky
Copy link
Contributor

mmcky commented Aug 2, 2022

@AakashGfude can you review this -- is this still an issue?

@AakashGfude
Copy link
Member

hi @mmcky looks like it is still an issue. From what I saw on the website. Probably because the PR executablebooks/MyST-NB#305 wasn't merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants