Skip to content

[short_path] Editorial Suggestions #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
HumphreyYang opened this issue Jun 26, 2024 · 3 comments
Closed
7 tasks done

[short_path] Editorial Suggestions #470

HumphreyYang opened this issue Jun 26, 2024 · 3 comments
Assignees

Comments

@HumphreyYang
Copy link
Collaborator

HumphreyYang commented Jun 26, 2024

Comments by @SylviaZhaooo.

  • Delete one of the etc. and make the dot points the complete sentence (remove the capitalization).
  • Improve all the graphs in the lecture -- the number is not clear in the path (@mmcky) [short_path_graph] Update all graphs #480
  • "preceding example" -> "preceding example."
  • Bold Bellman Equation and get a Wikipedia link to Bellman
  • np.inf to np.inf
  • Change the shortest path code to the cleaner version @SylviaZhaooo and also in the exercise.
  • change np.array_equal to np.allclose
@mmcky
Copy link
Contributor

mmcky commented Jul 1, 2024

@SylviaZhaooo can you confirm if this has been done in your update PR?

  • change it to np.allclose()

@HumphreyYang
Copy link
Collaborator Author

HumphreyYang commented Jul 1, 2024

Many thanks @mmcky and @SylviaZhaooo. The item should be

  • change np.array_equal to np.allclose

I should have updated this after the meeting : )

@SylviaZhaooo
Copy link
Collaborator

@SylviaZhaooo can you confirm if this has been done in your update PR?

  • change it to np.allclose()

Sorry for the late reply, I think this has been done.

@jstac jstac closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants