Skip to content

Improve lake model #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jstac opened this issue Apr 23, 2023 · 4 comments · Fixed by #179
Closed

Improve lake model #173

jstac opened this issue Apr 23, 2023 · 4 comments · Fixed by #179
Assignees

Comments

@jstac
Copy link
Contributor

jstac commented Apr 23, 2023

@HengchengZhang , could you please review the lecture lake_model.md as follows:

There are references to the Perron-Frobenius theorem. They should be linked to our presentation of that theorem in eigen_II.md.

The exercise and solution environments need to be set up properly.

Tidy up any messy equations --- used aligned if necessary.

Spell check.

Break up into subsections. Start the lecture with ## Outline. Then perhaps ## The Model followed by ## Dynamics.

"colsum" should not be italic.

Use proper inner product symbols.

@HengchengZhang
Copy link
Member

HengchengZhang commented Apr 26, 2023

Hi @jstac, when fixing the messy equations I noticed that the way we use matrices and vectors is quite different in different lectures, like in Markov Chains.

Shall we also be uniform at this?

Also a note to myself:

  • Reference eigen_II.md
  • Set up exercise environment
  • Tidy up equations
  • Spell check
  • Break up into subsctions
  • Non-italic colcum
  • Proper inner product

@jstac
Copy link
Contributor Author

jstac commented Apr 26, 2023

Thanks @HengchengZhang .

What do you mean by "the way we use"? Can you give an example?

Do you mean the notation $P(x,y)$ instead of $P_{ij}$?

(It's a bit irregular but helpful in the case of Markov chains.)

@HengchengZhang
Copy link
Member

Thanks John, it's the use of parentheses(using bmatrix) and brackets(using array).

@jstac
Copy link
Contributor Author

jstac commented Apr 26, 2023

Ah, you mean that we use pmatrix instead of bmatrix? Good catch.

(Please be ask specific as possible with your comments so I can figure out what you mean quickly.)

The style guide says we should use bmatrix so I guess we'd better follow it (even though I prefer pmatrix...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants