Skip to content

Bugs / warnings in networks lecture #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jstac opened this issue Apr 23, 2023 · 5 comments
Closed

Bugs / warnings in networks lecture #170

jstac opened this issue Apr 23, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@jstac
Copy link
Contributor

jstac commented Apr 23, 2023

networks.md is failing to build --- see, for example, https://6444c07a5860295daead11a1--taupe-gaufre-c4e660.netlify.app/networks.html (or some other deployment).

There are also future warnings that need to be dealt with.

CC @Smit-create @HumphreyYang

@jstac jstac added the bug Something isn't working label Apr 23, 2023
@Smit-create
Copy link
Member

Thanks, I'll have a look at it. I think I have also come across this error sometime earlier and probably it has something to do with how the graphviz is installed. I will have to look into it in more detail locally.

@jstac
Copy link
Contributor Author

jstac commented Apr 23, 2023

Thanks @Smit-create . Please note https://manual.quantecon.org/writing/styleguide.html#binary-packages-with-python-frontends

(Also, it would be great if you or @HumphreyYang could fix the future warnings.)

@HumphreyYang
Copy link
Collaborator

Many thanks @jstac and @Smit-create.

I will look into the future error.

@HumphreyYang
Copy link
Collaborator

Hi @jstac,

The FutureWarning has been addressed here.

There is a reference issue on the network book website that takes me to book-dp1 GitHub repo. It is mentioned in book-dp1#11

Apologies for confusing the titles for the two repos above as they are too similar in my browser tag : )

Many thanks.

@jstac
Copy link
Contributor Author

jstac commented Jun 7, 2023

OK to close this @HumphreyYang ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants