MAINT: address review comments

Author: ev-br

torch_np/_detail/_ufunc_impl.py

@@ -146,8 +146,8 @@ def _absolute(x):
 def _matmul(x, y):
     # work around RuntimeError: expected scalar type Int but found Double
     dtype = _dtypes_impl.result_type_impl((x.dtype, y.dtype))
-    x = x.to(dtype)
-    y = y.to(dtype)
+    x = _util.cast_if_needed(x, dtype)
+    y = _util.cast_if_needed(y, dtype)
     result = torch.matmul(x, y)
     return result
 

torch_np/_detail/implementations.py

@@ -507,7 +507,7 @@ def arange(start=None, stop=None, step=1, dtype=None):
 
     if (step > 0 and start > stop) or (step < 0 and start < stop):
         # empty range
-        return torch.empty(0, dtype=target_type)
+        return torch.empty(0, dtype=target_dtype)
 
     try:
         result = torch.arange(start, stop, step, dtype=work_dtype)
@@ -797,6 +797,10 @@ def vdot(t_a, t_b, /):
 
 
 def dot(t_a, t_b):
+    dtype = _dtypes_impl.result_type_impl((t_a.dtype, t_b.dtype))
+    t_a = _util.cast_if_needed(t_a, dtype)
+    t_b = _util.cast_if_needed(t_b, dtype)
+
     if t_a.ndim == 0 or t_b.ndim == 0:
         result = t_a * t_b
     elif t_a.ndim == 1 and t_b.ndim == 1:

torch_np/_funcs.py

@@ -101,9 +101,6 @@ def vdot(a, b, /):
 
 def dot(a, b, out=None):
     t_a, t_b = _helpers.to_tensors(a, b)
-    dtype = _dtypes_impl.result_type_impl((t_a.dtype, t_b.dtype))
-    t_a = t_a.to(dtype)
-    t_b = t_b.to(dtype)
     result = _impl.dot(t_a, t_b)
     return _helpers.result_or_out(result, out)