MAINT: address review comments

Author: ev-br

torch_np/_detail/_flips.py

@@ -32,7 +32,12 @@ def swapaxes(tensor, axis1, axis2):
     return torch.swapaxes(tensor, axis1, axis2)
 
 
+# Straight vendor from:
 # https://github.com/numpy/numpy/blob/v1.24.0/numpy/core/numeric.py#L1259
+#
+# Also note this function in NumPy is mostly retained for backwards compat
+# (https://stackoverflow.com/questions/29891583/reason-why-numpy-rollaxis-is-so-confusing)
+# so let's not touch it unless hard pressed.
 def rollaxis(tensor, axis, start=0):
     n = tensor.ndim
     axis = _util.normalize_axis_index(axis, n)

torch_np/tests/numpy_tests/lib/test_function_base.py

@@ -130,7 +130,7 @@ def test_axes(self):
         assert_raises(np.AxisError, np.flip, np.ones((4, 4)), axis=-3)
         assert_raises(np.AxisError, np.flip, np.ones((4, 4)), axis=(0, 3))
 
-    @pytest.mark.xfail(reason='no [::-1] indexing')
+    @pytest.mark.skip(reason='no [::-1] indexing')
     def test_basic_lr(self):
         a = get_mat(4)
         b = a[:, ::-1]
@@ -141,7 +141,7 @@ def test_basic_lr(self):
              [5, 4, 3]]
         assert_equal(np.flip(a, 1), b)
 
-    @pytest.mark.xfail(reason='no [::-1] indexing')
+    @pytest.mark.skip(reason='no [::-1] indexing')
     def test_basic_ud(self):
         a = get_mat(4)
         b = a[::-1, :]