Skip to content

Commit ac07b1f

Browse files
committed
Remove note on NotImplemented annotation
1 parent e3c492b commit ac07b1f

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

RFC.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -275,11 +275,6 @@ writing `torch_np.ndarray` above to make more explicit our intents, but there
275275
shouldn't be any ambiguity.
276276

277277
**OBS(Lezcano)**: `DTypeLike` should be `Optional[DTypeLike]`
278-
**OBS(Lezcano)**: Should we have a `NotImplementedType` to mark the args that
279-
are not being implemented? We could then assert that either that parameter has
280-
not been provided, and if it has, it has the same value as the default. The
281-
goal here would be to either use all the args of a function in its
282-
implementation, or mark explicitly those that we don't use.
283278

284279
**Implmenting out**: In PyTorch, the `out` kwarg is, as the name says, a
285280
keyword-only argument. It is for this reason that, in PrimTorch, we were able

0 commit comments

Comments
 (0)