BUG: fix out1, out2 logic in divmod

Author: ev-br

torch_np/_ufuncs.py

@@ -128,13 +128,14 @@ def divmod(
     num_outs = sum(x is not None for x in [out1, out2])
     if num_outs == 1:
         raise ValueError("both out1 and out2 need to be provided")
+    elif num_outs == 2:
+        o1, o2 = out
+        if o1 is not None or o2 is not None:
+            raise TypeError(
+                "cannot specify 'out' as both a positional and keyword argument"
+            )
     else:
         out1, out2 = out
-        if num_outs == 2:
-            if out1 is not None or out2 is not None:
-                raise TypeError(
-                    "cannot specify 'out' as both a positional and keyword argument"
-                )
 
     tensors = _ufunc_preprocess(
         (x1, x2), True, casting, order, dtype, subok, signature, extobj

torch_np/tests/test_basic.py

@@ -475,6 +475,18 @@ def test_divmod_out_list(self):
         assert quot is out[0]
         assert rem is out[1]
 
+    @pytest.mark.xfail(reason="out1, out2 not implemented")
+    def test_divmod_pos_only(self):
+        x1 = [4, 5, 6]
+        x2 = [2, 1, 2]
+
+        out1, out2 = w.empty_like(x1), w.empty_like(x1)
+
+        quot, rem = w.divmod(x1, x2, out1, out2)
+
+        assert quot is out1
+        assert rem is out2
+
     def test_divmod_no_out(self):
         # check that the out= machinery handles no out at all
         x1 = w.array([4, 5, 6])