MAINT: apply suggestions from review

Author: ev-br

autogen/numpy_api_dump.py

@@ -875,10 +875,6 @@ def tensordot(a, b, axes=2):
     raise NotImplementedError
 
 
-def tile(A, reps):
-    raise NotImplementedError
-
-
 def trace(a, offset=0, axis1=0, axis2=1, dtype=None, out=None):
     raise NotImplementedError
 

torch_np/_detail/implementations.py

@@ -46,7 +46,7 @@ def split_helper_int(tensor, indices_or_sections, axis, strict=False):
         num, sz = l % n, l // n + 1
         lst = [sz] * num
 
-   lst += [sz - 1] * (n - num)
+    lst += [sz - 1] * (n - num)
 
     result = torch.split(tensor, lst, axis)
 
@@ -61,7 +61,7 @@ def split_helper_list(tensor, indices_or_sections, axis, strict=False):
     lst = [x for x in indices_or_sections if x <= tensor.shape[axis]]
     num_extra = len(indices_or_sections) - len(lst)
 
-    lst = lst + [tensor.shape[axis]]
+    lst.append(tensor.shape[axis])
     lst = [
         lst[0],
     ] + [a - b for a, b in zip(lst[1:], lst[:-1])]

torch_np/_wrapper.py

@@ -166,7 +166,7 @@ def array_split(ary, indices_or_sections, axis=0):
 
     result = _impl.split_helper(tensor, indices_or_sections, axis)
 
-    return tuple(maybe_set_base(_, base) for _ in result)
+    return tuple(maybe_set_base(x, base) for x in result)
 
 
 def split(ary, indices_or_sections, axis=0):
@@ -176,7 +176,7 @@ def split(ary, indices_or_sections, axis=0):
 
     result = _impl.split_helper(tensor, indices_or_sections, axis, strict=True)
 
-    return tuple(maybe_set_base(_, base) for _ in result)
+    return tuple(maybe_set_base(x, base) for x in result)
 
 
 def hsplit(ary, indices_or_sections):
@@ -190,7 +190,7 @@ def hsplit(ary, indices_or_sections):
 
     result = _impl.split_helper(tensor, indices_or_sections, axis, strict=True)
 
-    return tuple(maybe_set_base(_, base) for _ in result)
+    return tuple(maybe_set_base(x, base) for x in result)
 
 
 def vsplit(ary, indices_or_sections):
@@ -201,7 +201,7 @@ def vsplit(ary, indices_or_sections):
         raise ValueError("vsplit only works on arrays of 2 or more dimensions")
     result = _impl.split_helper(tensor, indices_or_sections, 0, strict=True)
 
-    return tuple(maybe_set_base(_, base) for _ in result)
+    return tuple(maybe_set_base(x, base) for x in result)
 
 
 def dsplit(ary, indices_or_sections):
@@ -212,7 +212,7 @@ def dsplit(ary, indices_or_sections):
         raise ValueError("dsplit only works on arrays of 3 or more dimensions")
     result = _impl.split_helper(tensor, indices_or_sections, 2, strict=True)
 
-    return tuple(maybe_set_base(_, base) for _ in result)
+    return tuple(maybe_set_base(x, base) for x in result)
 
 
 def kron(a, b):