Skip to content

Commit 9caf080

Browse files
committed
TST: unfail test_numeric/TestBoolCmp
1 parent 2240211 commit 9caf080

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

torch_np/tests/numpy_tests/core/test_numeric.py

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,6 @@ def test_logical_and_or_xor(self):
453453
assert_array_equal(self.im ^ False, self.im)
454454

455455

456-
@pytest.mark.xfail(reason="TODO: needs fancy indexing")
457456
class TestBoolCmp:
458457
def setup_method(self):
459458
self.f = np.ones(256, dtype=np.float32)
@@ -515,10 +514,6 @@ def test_float(self):
515514
r3 = 0 != self.f[i:]
516515
assert_array_equal(r, r2)
517516
assert_array_equal(r, r3)
518-
# check bool == 0x1
519-
assert_array_equal(r.view(np.int8), r.astype(np.int8))
520-
assert_array_equal(r2.view(np.int8), r2.astype(np.int8))
521-
assert_array_equal(r3.view(np.int8), r3.astype(np.int8))
522517

523518
# isnan on amd64 takes the same code path
524519
assert_array_equal(np.isnan(self.nf[i:]), self.ef[i:])
@@ -527,6 +522,17 @@ def test_float(self):
527522
assert_array_equal(np.isinf(self.inff[i:]), self.efnonan[i:])
528523
assert_array_equal(np.signbit(self.signf[i:]), self.ef[i:])
529524

525+
@pytest.mark.xfail(reason='no .view method')
526+
def test_float_2(self):
527+
for i in range(4):
528+
r = self.f[i:] != 0
529+
r2 = self.f[i:] != np.zeros_like(self.f[i:])
530+
r3 = 0 != self.f[i:]
531+
# check bool == 0x1
532+
assert_array_equal(r.view(np.int8), r.astype(np.int8))
533+
assert_array_equal(r2.view(np.int8), r2.astype(np.int8))
534+
assert_array_equal(r3.view(np.int8), r3.astype(np.int8))
535+
530536
def test_double(self):
531537
# offset for alignment test
532538
for i in range(2):
@@ -541,10 +547,6 @@ def test_double(self):
541547
r3 = 0 != self.d[i:]
542548
assert_array_equal(r, r2)
543549
assert_array_equal(r, r3)
544-
# check bool == 0x1
545-
assert_array_equal(r.view(np.int8), r.astype(np.int8))
546-
assert_array_equal(r2.view(np.int8), r2.astype(np.int8))
547-
assert_array_equal(r3.view(np.int8), r3.astype(np.int8))
548550

549551
# isnan on amd64 takes the same code path
550552
assert_array_equal(np.isnan(self.nd[i:]), self.ed[i:])
@@ -553,6 +555,18 @@ def test_double(self):
553555
assert_array_equal(np.isinf(self.infd[i:]), self.ednonan[i:])
554556
assert_array_equal(np.signbit(self.signd[i:]), self.ed[i:])
555557

558+
@pytest.mark.xfail(reason='no .view method')
559+
def test_double_2(self):
560+
for i in range(4):
561+
r = self.d[i:] != 0
562+
r2 = self.d[i:] != np.zeros_like(self.d[i:])
563+
r3 = 0 != self.d[i:]
564+
565+
# check bool == 0x1
566+
assert_array_equal(r.view(np.int8), r.astype(np.int8))
567+
assert_array_equal(r2.view(np.int8), r2.astype(np.int8))
568+
assert_array_equal(r3.view(np.int8), r3.astype(np.int8))
569+
556570

557571
@pytest.mark.xfail(reason="TODO")
558572
class TestSeterr:

0 commit comments

Comments
 (0)