ENH: add array.view, test_numeric/TestBoolCmp

Author: ev-br

torch_np/_ndarray.py

@@ -159,6 +159,13 @@ def copy(self, order="C"):
         tensor = self._tensor.clone()
         return ndarray._from_tensor_and_base(tensor, None)
 
+    def view(self, dtype):
+        # XXX: 1) make dtype_to_torch decorator understand positional args
+        #      2) rid of .base and _from_tensor_and_base
+        torch_dtype = _dtypes.dtype(dtype).torch_dtype
+        tview = self._tensor.view(torch_dtype)
+        return ndarray._from_tensor_and_base(tview, self)
+
     def tolist(self):
         return self._tensor.tolist()
 

torch_np/tests/numpy_tests/core/test_numeric.py

@@ -453,7 +453,6 @@ def test_logical_and_or_xor(self):
         assert_array_equal(self.im ^ False, self.im)
 
 
-@pytest.mark.xfail(reason="TODO: needs fancy indexing")
 class TestBoolCmp:
     def setup_method(self):
         self.f = np.ones(256, dtype=np.float32)
@@ -515,6 +514,7 @@ def test_float(self):
             r3 = 0 != self.f[i:]
             assert_array_equal(r, r2)
             assert_array_equal(r, r3)
+
             # check bool == 0x1
             assert_array_equal(r.view(np.int8), r.astype(np.int8))
             assert_array_equal(r2.view(np.int8), r2.astype(np.int8))
@@ -541,6 +541,7 @@ def test_double(self):
             r3 = 0 != self.d[i:]
             assert_array_equal(r, r2)
             assert_array_equal(r, r3)
+
             # check bool == 0x1
             assert_array_equal(r.view(np.int8), r.astype(np.int8))
             assert_array_equal(r2.view(np.int8), r2.astype(np.int8))