Skip to content

Commit 0210366

Browse files
committed
MAINT: remove outdated comments
1 parent a0cb202 commit 0210366

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

torch_np/_normalizations.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ def wrapped(*args, **kwds):
127127
# loop over positional parameters and actual arguments
128128
lst, dct = [], {}
129129
for arg, (name, parm) in zip(args, sig.parameters.items()):
130-
print(arg, name, parm.annotation)
131130
lst.append(normalize_this(arg, parm, return_on_failure))
132131

133132
# normalize keyword arguments
@@ -138,7 +137,6 @@ def wrapped(*args, **kwds):
138137
f"{func.__name__}() got an unexpected keyword argument '{name}'."
139138
)
140139

141-
print("kw: ", name, sig.parameters[name].annotation)
142140
parm = sig.parameters[name]
143141
dct[name] = normalize_this(arg, parm, return_on_failure)
144142

@@ -152,20 +150,6 @@ def wrapped(*args, **kwds):
152150
raise TypeError(
153151
f"{func.__name__}() takes {len(ba.args)} positional argument but {len(args)} were given."
154152
)
155-
156-
# TODO:
157-
# 1. [LOOKS OK] kw-only parameters : see vstack
158-
# 2. [LOOKS OK] extra unknown args -- error out : nonzero([2, 0, 3], oops=42)
159-
# 3. [LOOKS OK] optional (tensor_or_none) : untyped => pass through
160-
# 4. [LOOKS OK] DTypeLike : positional or kw
161-
# 5. axes : live in _impl or in types? several ways of handling them
162-
# 6. [OK, NOT HERE] keepdims : peel off, postprocess
163-
# 7. OutLike : normal & keyword-only, peel off, postprocess
164-
# 8. [LOOKS OK] *args
165-
# 9. [LOOKS OK] consolidate normalizations (_funcs, _wrapper)
166-
# 10. [LOOKS OK] consolidate decorators (_{unary,binary}_ufuncs)
167-
# 11. out= arg : validate it's an ndarray
168-
169153
# finally, pass normalized arguments through
170154
result = func(*ba.args, **ba.kwargs)
171155
return result

0 commit comments

Comments
 (0)