Skip to content

Commit b31f36c

Browse files
QuailtyDevQuailtyDev
committed
test(form): Fix unit tests
SEE testing-library/dom-testing-library#474
1 parent 37b828c commit b31f36c

File tree

6 files changed

+22
-20
lines changed

6 files changed

+22
-20
lines changed

‎__tests__/components/form/login.spec.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,25 +10,25 @@ describe('<LoginForm />', () => {
1010
});
1111

1212
it('should require the fields', async () => {
13-
const { getByRole, getByText } = render(<LoginForm onSubmit={jest.fn} />);
13+
const { getByTitle, getByText } = render(<LoginForm onSubmit={jest.fn} />);
1414

1515
await act(async () => {
16-
fireEvent.submit(getByRole('form'));
16+
fireEvent.submit(getByTitle('login form'));
1717
});
1818

1919
expect(getByText(validations.username.required)).toBeInTheDocument();
2020
expect(getByText(validations.password.required)).toBeInTheDocument();
2121
});
2222

2323
it('should validate the length of fields', async () => {
24-
const { getByLabelText, getByRole, getByText } = render(
24+
const { getByLabelText, getByTitle, getByText } = render(
2525
<LoginForm onSubmit={jest.fn} />,
2626
);
2727

2828
userEvent.type(getByLabelText(/Username/), 'user');
2929
userEvent.type(getByLabelText(/Password/), 'pwd');
3030
await act(async () => {
31-
fireEvent.submit(getByRole('form'));
31+
fireEvent.submit(getByTitle('login form'));
3232
});
3333

3434
expect(
@@ -41,14 +41,14 @@ describe('<LoginForm />', () => {
4141

4242
it('should submit the form', async () => {
4343
const handleSubmit = jest.fn();
44-
const { getByLabelText, getByRole } = render(
44+
const { getByLabelText, getByTitle } = render(
4545
<LoginForm onSubmit={handleSubmit} />,
4646
);
4747

4848
userEvent.type(getByLabelText(/Username/), 'admin');
4949
userEvent.type(getByLabelText(/Password/), 'Pa$$w0rd!');
5050
await act(async () => {
51-
fireEvent.submit(getByRole('form'));
51+
fireEvent.submit(getByTitle('login form'));
5252
});
5353

5454
expect(handleSubmit).toHaveBeenCalledWith(

‎__tests__/components/form/register.spec.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ describe('<RegisterForm />', () => {
99
});
1010

1111
it('should require the fields', async () => {
12-
const { getByRole, getByText } = render(
12+
const { getByTitle, getByText } = render(
1313
<RegisterForm onSubmit={jest.fn as any} />,
1414
);
1515

1616
await act(async () => {
17-
fireEvent.submit(getByRole('form'));
17+
fireEvent.submit(getByTitle('register form'));
1818
});
1919

2020
expect(getByText(validations.firstName.required)).toBeInTheDocument();
@@ -25,7 +25,7 @@ describe('<RegisterForm />', () => {
2525

2626
it('should submit the form', async () => {
2727
const handleSubmit = jest.fn();
28-
const { getByLabelText, getByRole } = render(
28+
const { getByLabelText, getByTitle } = render(
2929
<RegisterForm onSubmit={handleSubmit} />,
3030
);
3131

@@ -34,7 +34,7 @@ describe('<RegisterForm />', () => {
3434
userEvent.type(getByLabelText(/Email/i), '[email protected]');
3535
userEvent.type(getByLabelText(/Password/i), 'Pa$$w0rd!');
3636
await act(async () => {
37-
fireEvent.submit(getByRole('form'));
37+
fireEvent.submit(getByTitle('register form'));
3838
});
3939

4040
expect(handleSubmit).toHaveBeenCalledWith(

‎__tests__/pages/login.spec.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ describe('<loginPage />', () => {
4545
}`,
4646
{ status: 401 },
4747
);
48-
const { getByLabelText, getByRole, getByText } = render(tree);
48+
const { getByLabelText, getByTitle, getByText } = render(tree);
4949

5050
userEvent.type(getByLabelText(/Username/), 'nobody');
5151
userEvent.type(getByLabelText(/Password/), 'Pa$$w0rd!');
5252
await act(async () => {
53-
fireEvent.submit(getByRole('form'));
53+
fireEvent.submit(getByTitle('login form'));
5454
});
5555

5656
const errorMessage = await waitForElement(() =>
@@ -68,12 +68,12 @@ describe('<loginPage />', () => {
6868
}`,
6969
{ status: 401 },
7070
);
71-
const { getByLabelText, getByRole, getByText } = render(tree);
71+
const { getByLabelText, getByTitle, getByText } = render(tree);
7272

7373
userEvent.type(getByLabelText(/Username/), 'admin');
7474
userEvent.type(getByLabelText(/Password/), 'ji32k7au4a83');
7575
await act(async () => {
76-
fireEvent.submit(getByRole('form'));
76+
fireEvent.submit(getByTitle('login form'));
7777
});
7878

7979
const errorMessage = await waitForElement(() =>
@@ -90,12 +90,12 @@ describe('<loginPage />', () => {
9090
"picture": "https://i.pravatar.cc/200",
9191
"bio": "Lorem ipsum dolorem"
9292
}`);
93-
const { getByLabelText, getByRole } = render(tree);
93+
const { getByLabelText, getByTitle } = render(tree);
9494

9595
userEvent.type(getByLabelText(/Username/), 'admin');
9696
userEvent.type(getByLabelText(/Password/), 'Pa$$w0rd!');
9797
await act(async () => {
98-
fireEvent.submit(getByRole('form'));
98+
fireEvent.submit(getByTitle('login form'));
9999
});
100100

101101
expect(spyRouterPush).toHaveBeenCalledTimes(1);

‎__tests__/pages/register.spec.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ describe('<RegisterPage />', () => {
4646
}`,
4747
{ status: 409 },
4848
);
49-
const { getByLabelText, getByRole, getByText } = render(tree);
49+
const { getByLabelText, getByTitle, getByText } = render(tree);
5050

5151
userEvent.type(getByLabelText(/First name/i), 'Jane');
5252
userEvent.type(getByLabelText(/Last name/i), 'Doe');
5353
userEvent.type(getByLabelText(/Email/i), '[email protected]');
5454
userEvent.type(getByLabelText(/Password/i), '!drowssap');
5555

5656
await act(async () => {
57-
fireEvent.submit(getByRole('form'));
57+
fireEvent.submit(getByTitle('register form'));
5858
});
5959

6060
await expect(
@@ -70,15 +70,15 @@ describe('<RegisterPage />', () => {
7070
"picture": "https://i.pravatar.cc/200",
7171
"bio": "Lorem ipsum dolorem"
7272
}`);
73-
const { getByLabelText, getByRole } = render(tree);
73+
const { getByLabelText, getByTitle } = render(tree);
7474

7575
userEvent.type(getByLabelText(/First name/i), 'Kristen');
7676
userEvent.type(getByLabelText(/Last name/i), 'Williams');
7777
userEvent.type(getByLabelText(/Email/i), '[email protected]');
7878
userEvent.type(getByLabelText(/Password/i), 'Pa$$w0rd!');
7979

8080
await act(async () => {
81-
fireEvent.submit(getByRole('form'));
81+
fireEvent.submit(getByTitle('register form'));
8282
});
8383

8484
expect(spyRouterPush).toHaveBeenCalledTimes(1);

‎components/forms/login/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ const LoginForm: React.FC<PropTypes.InferProps<typeof propTypes>> = props => {
3939

4040
return (
4141
<form
42+
title="login form"
4243
className={classes.root}
4344
noValidate
4445
onSubmit={handleSubmit(props.onSubmit)}

‎components/forms/register/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ const RegisterForm: React.FC<RegisterFormProps> = props => {
4848

4949
return (
5050
<form
51+
title="register form"
5152
className={classes.root}
5253
noValidate
5354
onSubmit={handleSubmit(props.onSubmit)}

0 commit comments

Comments
 (0)