refs #281 MSAccess fixes

Duplicate now working.  DROP TABLE IF EXISTS does not seem to work reliably through Jackcess, so added a workaround.  The lastrowid was not being returned due to the nature of the executing a list of queries, so grabbed the inserted id after all of the queries were finished.

Author: PySimpleSQL

examples/MSAccess_examples/Journal.accdb

@@ -1019,7 +1019,7 @@ def requery(
         rows = self.driver.execute(query)
         self.rows = rows
 
-        if len(self.rows.index):
+        if len(self.rows.index) and self.pk_column is not None:
             if "sort_order" not in self.rows.attrs:
                 # Store the sort order as a dictionary in the attrs of the DataFrame
                 sort_order = self.rows[self.pk_column].to_list()
@@ -7758,25 +7758,31 @@ def execute(
                     row[column_name] = value
                 rows.append(row)
 
-            return Result.set(rows, None, exception, column_info)
+                # Set the last row ID
+                lastrowid = None
+                if "insert" in query.lower():
+                    res = self.execute("SELECT @@IDENTITY AS ID")
+                    lastrowid = res.iloc[0]["ID"]
+
+            return Result.set(rows, lastrowid, exception, column_info)
 
-        affected_rows = stmt.getUpdateCount()
-        return Result.set([], affected_rows, exception, column_info)
+        stmt.getUpdateCount()
+        return Result.set([], None, exception, column_info)
 
     def column_info(self, table):
         meta_data = self.con.getMetaData()
         rs = meta_data.getColumns(None, None, table, None)
-        print("Getting column info...")
+
         col_info = ColumnInfo(self, table)
         pk_columns = [self.pk_column(table)]
-        print("pk_columns", pk_columns)
+
         while rs.next():
             name = str(rs.getString("column_name"))
             domain = str(rs.getString("TYPE_NAME")).upper()
             notnull = str(rs.getString("IS_NULLABLE")) == "NO"
             default = str(rs.getString("COLUMN_DEF"))
             pk = name in pk_columns
-            print("name", name)
+
             col_info.append(
                 Column(
                     name=name, domain=domain, notnull=notnull, default=default, pk=pk
@@ -7786,7 +7792,6 @@ def column_info(self, table):
         return col_info
 
     def pk_column(self, table):
-        print(f"Getting pk_column for {table}")
         meta_data = self.con.getMetaData()
         rs = meta_data.getPrimaryKeys(None, None, table)
         if rs.next():
@@ -7859,12 +7864,12 @@ def _get_column_definitions(self, table_name):
         # Creates a comma separated list of column names and types to be used in a
         # CREATE TABLE statement
         columns = self.column_info(table_name)
-        print("columns", columns)
+
         cols = ""
         for c in columns:
             cols += f"{c['name']} {c['domain']}, "
         cols = cols[:-2]
-        print("\ncols\n", cols)
+
         return cols
 
     def duplicate_record(self, dataset: DataSet, children: bool) -> pd.DataFrame:
@@ -7883,9 +7888,11 @@ def duplicate_record(self, dataset: DataSet, children: bool) -> pd.DataFrame:
         description_column = dataset.description_column
 
         # Create tmp table, update pk column in temp and insert into table
-        f"WHERE {pk_column}={dataset.get_current(dataset.pk_column)}"
-        query = [
-            f"DROP TABLE IF EXISTS [{tmp_table}];",
+        query = []
+        if tmp_table in self.get_tables():
+            query.append(f"DROP TABLE [{tmp_table}];")
+
+        query += [
             f"CREATE TABLE [{tmp_table}] ({self._get_column_definitions(table)});",
             (
                 f"INSERT INTO [{tmp_table}] (SELECT * FROM [{table}] "
@@ -7897,15 +7904,16 @@ def duplicate_record(self, dataset: DataSet, children: bool) -> pd.DataFrame:
             ),
             f"UPDATE [{tmp_table}] SET {description_column} = {description}",
             f"INSERT INTO [{table}] SELECT * FROM [{tmp_table}];",
-            f"DROP TABLE IF EXISTS [{tmp_table}]",
+            f"DROP TABLE [{tmp_table}]",
         ]
         for q in query:
-            res = self.execute(q)
+            res = self.execute(q, auto_commit_rollback=True)
             if res.attrs["exception"]:
                 return res
 
         # Now we save the new pk
-        pk = res.attrs["lastrowid"]
+        res = self.execute("SELECT @@IDENTITY AS ID")
+        lastrowid = res.loc[0]["ID"]
 
         # create list of which children we have duplicated
         child_duplicated = []
@@ -7925,8 +7933,11 @@ def duplicate_record(self, dataset: DataSet, children: bool) -> pd.DataFrame:
 
                         # Update children's pk_columns to NULL and set correct parent
                         # PK value.
-                        queries = [
-                            f"DROP TABLE IF EXISTS [{tmp_child}]",
+                        query = []
+                        if tmp_child in self.get_tables():
+                            query.append(f"DROP TABLE [{tmp_child}];")
+
+                        query += [
                             (
                                 f"CREATE TABLE [{tmp_table}] "
                                 f"({self._get_column_definitions(table)});"
@@ -7940,7 +7951,7 @@ def duplicate_record(self, dataset: DataSet, children: bool) -> pd.DataFrame:
                             f"UPDATE [{tmp_child}] SET {pk_column} = NULL;",
                             f"UPDATE [{tmp_child}] SET {fk_column} = {pk}",
                             f"INSERT INTO [{child}] SELECT * FROM [{tmp_child}];",
-                            f"DROP TABLE IF EXISTS [{tmp_child}]",
+                            f"DROP TABLE [{tmp_child}]",
                         ]
                         for q in queries:
                             res = self.execute(q)
@@ -7950,7 +7961,7 @@ def duplicate_record(self, dataset: DataSet, children: bool) -> pd.DataFrame:
                         child_duplicated.append(r.child_table)
         # If we made it here, we can return the pk.  Since the pk was stored earlier,
         # we will just send and empty DataFrame
-        return Result.set(lastrowid=pk)
+        return Result.set(lastrowid=lastrowid)
 
     def insert_record(self, table: str, pk: int, pk_column: str, row: dict):
         # Remove the pk column