Skip to content

Commit 81dbbc5

Browse files
author
adustman
committed
Update UnitTest methods deprecated in Python 2.7
1 parent 3070f46 commit 81dbbc5

File tree

5 files changed

+56
-55
lines changed

5 files changed

+56
-55
lines changed

MySQLdb/tests/capabilities.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,12 @@ def generator(row, col):
127127
self.cursor.execute('select col1 from %s where col1=%s' % \
128128
(self.table, 0))
129129
l = self.cursor.fetchall()
130-
self.failIf(l, "DELETE didn't work")
130+
self.assertFalse(l, "DELETE didn't work")
131131
self.connection.rollback()
132132
self.cursor.execute('select col1 from %s where col1=%s' % \
133133
(self.table, 0))
134134
l = self.cursor.fetchall()
135-
self.failUnless(len(l) == 1, "ROLLBACK didn't work")
135+
self.assertTrue(len(l) == 1, "ROLLBACK didn't work")
136136
self.cursor.execute('drop table %s' % (self.table))
137137

138138
def test_truncation(self):

MySQLdb/tests/dbapi20.py

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def test_threadsafety(self):
159159
# Must exist
160160
threadsafety = self.driver.threadsafety
161161
# Must be a valid value
162-
self.failUnless(threadsafety in (0,1,2,3))
162+
self.assertTrue(threadsafety in (0,1,2,3))
163163
except AttributeError:
164164
self.fail("Driver doesn't define threadsafety")
165165

@@ -168,7 +168,7 @@ def test_paramstyle(self):
168168
# Must exist
169169
paramstyle = self.driver.paramstyle
170170
# Must be a valid value
171-
self.failUnless(paramstyle in (
171+
self.assertTrue(paramstyle in (
172172
'qmark','numeric','named','format','pyformat'
173173
))
174174
except AttributeError:
@@ -177,27 +177,27 @@ def test_paramstyle(self):
177177
def test_Exceptions(self):
178178
# Make sure required exceptions exist, and are in the
179179
# defined heirarchy.
180-
self.failUnless(issubclass(self.driver.Warning,StandardError))
181-
self.failUnless(issubclass(self.driver.Error,StandardError))
182-
self.failUnless(
180+
self.assertTrue(issubclass(self.driver.Warning,StandardError))
181+
self.assertTrue(issubclass(self.driver.Error,StandardError))
182+
self.assertTrue(
183183
issubclass(self.driver.InterfaceError,self.driver.Error)
184184
)
185-
self.failUnless(
185+
self.assertTrue(
186186
issubclass(self.driver.DatabaseError,self.driver.Error)
187187
)
188-
self.failUnless(
188+
self.assertTrue(
189189
issubclass(self.driver.OperationalError,self.driver.Error)
190190
)
191-
self.failUnless(
191+
self.assertTrue(
192192
issubclass(self.driver.IntegrityError,self.driver.Error)
193193
)
194-
self.failUnless(
194+
self.assertTrue(
195195
issubclass(self.driver.InternalError,self.driver.Error)
196196
)
197-
self.failUnless(
197+
self.assertTrue(
198198
issubclass(self.driver.ProgrammingError,self.driver.Error)
199199
)
200-
self.failUnless(
200+
self.assertTrue(
201201
issubclass(self.driver.NotSupportedError,self.driver.Error)
202202
)
203203

@@ -210,15 +210,15 @@ def test_ExceptionsAsConnectionAttributes(self):
210210
# by default.
211211
con = self._connect()
212212
drv = self.driver
213-
self.failUnless(con.Warning is drv.Warning)
214-
self.failUnless(con.Error is drv.Error)
215-
self.failUnless(con.InterfaceError is drv.InterfaceError)
216-
self.failUnless(con.DatabaseError is drv.DatabaseError)
217-
self.failUnless(con.OperationalError is drv.OperationalError)
218-
self.failUnless(con.IntegrityError is drv.IntegrityError)
219-
self.failUnless(con.InternalError is drv.InternalError)
220-
self.failUnless(con.ProgrammingError is drv.ProgrammingError)
221-
self.failUnless(con.NotSupportedError is drv.NotSupportedError)
213+
self.assertTrue(con.Warning is drv.Warning)
214+
self.assertTrue(con.Error is drv.Error)
215+
self.assertTrue(con.InterfaceError is drv.InterfaceError)
216+
self.assertTrue(con.DatabaseError is drv.DatabaseError)
217+
self.assertTrue(con.OperationalError is drv.OperationalError)
218+
self.assertTrue(con.IntegrityError is drv.IntegrityError)
219+
self.assertTrue(con.InternalError is drv.InternalError)
220+
self.assertTrue(con.ProgrammingError is drv.ProgrammingError)
221+
self.assertTrue(con.NotSupportedError is drv.NotSupportedError)
222222

223223

224224
def test_commit(self):
@@ -310,12 +310,12 @@ def test_rowcount(self):
310310
cur.execute("insert into %sbooze values ('Victoria Bitter')" % (
311311
self.table_prefix
312312
))
313-
self.failUnless(cur.rowcount in (-1,1),
313+
self.assertTrue(cur.rowcount in (-1,1),
314314
'cursor.rowcount should == number or rows inserted, or '
315315
'set to -1 after executing an insert statement'
316316
)
317317
cur.execute("select name from %sbooze" % self.table_prefix)
318-
self.failUnless(cur.rowcount in (-1,1),
318+
self.assertTrue(cur.rowcount in (-1,1),
319319
'cursor.rowcount should == number of rows returned, or '
320320
'set to -1 after executing a select statement'
321321
)
@@ -378,7 +378,7 @@ def _paraminsert(self,cur):
378378
cur.execute("insert into %sbooze values ('Victoria Bitter')" % (
379379
self.table_prefix
380380
))
381-
self.failUnless(cur.rowcount in (-1,1))
381+
self.assertTrue(cur.rowcount in (-1,1))
382382

383383
if self.driver.paramstyle == 'qmark':
384384
cur.execute(
@@ -407,7 +407,7 @@ def _paraminsert(self,cur):
407407
)
408408
else:
409409
self.fail('Invalid paramstyle')
410-
self.failUnless(cur.rowcount in (-1,1))
410+
self.assertTrue(cur.rowcount in (-1,1))
411411

412412
cur.execute('select name from %sbooze' % self.table_prefix)
413413
res = cur.fetchall()
@@ -459,7 +459,7 @@ def test_executemany(self):
459459
)
460460
else:
461461
self.fail('Unknown paramstyle')
462-
self.failUnless(cur.rowcount in (-1,2),
462+
self.assertTrue(cur.rowcount in (-1,2),
463463
'insert using cursor.executemany set cursor.rowcount to '
464464
'incorrect value %r' % cur.rowcount
465465
)
@@ -494,7 +494,7 @@ def test_fetchone(self):
494494
'cursor.fetchone should return None if a query retrieves '
495495
'no rows'
496496
)
497-
self.failUnless(cur.rowcount in (-1,0))
497+
self.assertTrue(cur.rowcount in (-1,0))
498498

499499
# cursor.fetchone should raise an Error if called after
500500
# executing a query that cannnot return rows
@@ -514,7 +514,7 @@ def test_fetchone(self):
514514
self.assertEqual(cur.fetchone(),None,
515515
'cursor.fetchone should return None if no more rows available'
516516
)
517-
self.failUnless(cur.rowcount in (-1,1))
517+
self.assertTrue(cur.rowcount in (-1,1))
518518
finally:
519519
con.close()
520520

@@ -570,7 +570,7 @@ def test_fetchmany(self):
570570
'cursor.fetchmany should return an empty sequence after '
571571
'results are exhausted'
572572
)
573-
self.failUnless(cur.rowcount in (-1,6))
573+
self.assertTrue(cur.rowcount in (-1,6))
574574

575575
# Same as above, using cursor.arraysize
576576
cur.arraysize=4
@@ -583,12 +583,12 @@ def test_fetchmany(self):
583583
self.assertEqual(len(r),2)
584584
r = cur.fetchmany() # Should be an empty sequence
585585
self.assertEqual(len(r),0)
586-
self.failUnless(cur.rowcount in (-1,6))
586+
self.assertTrue(cur.rowcount in (-1,6))
587587

588588
cur.arraysize=6
589589
cur.execute('select name from %sbooze' % self.table_prefix)
590590
rows = cur.fetchmany() # Should get all rows
591-
self.failUnless(cur.rowcount in (-1,6))
591+
self.assertTrue(cur.rowcount in (-1,6))
592592
self.assertEqual(len(rows),6)
593593
self.assertEqual(len(rows),6)
594594
rows = [r[0] for r in rows]
@@ -605,7 +605,7 @@ def test_fetchmany(self):
605605
'cursor.fetchmany should return an empty sequence if '
606606
'called after the whole result set has been fetched'
607607
)
608-
self.failUnless(cur.rowcount in (-1,6))
608+
self.assertTrue(cur.rowcount in (-1,6))
609609

610610
self.executeDDL2(cur)
611611
cur.execute('select name from %sbarflys' % self.table_prefix)
@@ -614,7 +614,7 @@ def test_fetchmany(self):
614614
'cursor.fetchmany should return an empty sequence if '
615615
'query retrieved no rows'
616616
)
617-
self.failUnless(cur.rowcount in (-1,0))
617+
self.assertTrue(cur.rowcount in (-1,0))
618618

619619
finally:
620620
con.close()
@@ -638,7 +638,7 @@ def test_fetchall(self):
638638

639639
cur.execute('select name from %sbooze' % self.table_prefix)
640640
rows = cur.fetchall()
641-
self.failUnless(cur.rowcount in (-1,len(self.samples)))
641+
self.assertTrue(cur.rowcount in (-1,len(self.samples)))
642642
self.assertEqual(len(rows),len(self.samples),
643643
'cursor.fetchall did not retrieve all rows'
644644
)
@@ -654,12 +654,12 @@ def test_fetchall(self):
654654
'cursor.fetchall should return an empty list if called '
655655
'after the whole result set has been fetched'
656656
)
657-
self.failUnless(cur.rowcount in (-1,len(self.samples)))
657+
self.assertTrue(cur.rowcount in (-1,len(self.samples)))
658658

659659
self.executeDDL2(cur)
660660
cur.execute('select name from %sbarflys' % self.table_prefix)
661661
rows = cur.fetchall()
662-
self.failUnless(cur.rowcount in (-1,0))
662+
self.assertTrue(cur.rowcount in (-1,0))
663663
self.assertEqual(len(rows),0,
664664
'cursor.fetchall should return an empty list if '
665665
'a select query returns no rows'
@@ -681,7 +681,7 @@ def test_mixedfetch(self):
681681
rows23 = cur.fetchmany(2)
682682
rows4 = cur.fetchone()
683683
rows56 = cur.fetchall()
684-
self.failUnless(cur.rowcount in (-1,6))
684+
self.assertTrue(cur.rowcount in (-1,6))
685685
self.assertEqual(len(rows23),2,
686686
'fetchmany returned incorrect number of rows'
687687
)
@@ -758,7 +758,7 @@ def test_arraysize(self):
758758
con = self._connect()
759759
try:
760760
cur = con.cursor()
761-
self.failUnless(hasattr(cur,'arraysize'),
761+
self.assertTrue(hasattr(cur,'arraysize'),
762762
'cursor.arraysize must be defined'
763763
)
764764
finally:
@@ -827,27 +827,27 @@ def test_Binary(self):
827827
b = self.driver.Binary('')
828828

829829
def test_STRING(self):
830-
self.failUnless(hasattr(self.driver,'STRING'),
830+
self.assertTrue(hasattr(self.driver,'STRING'),
831831
'module.STRING must be defined'
832832
)
833833

834834
def test_BINARY(self):
835-
self.failUnless(hasattr(self.driver,'BINARY'),
835+
self.assertTrue(hasattr(self.driver,'BINARY'),
836836
'module.BINARY must be defined.'
837837
)
838838

839839
def test_NUMBER(self):
840-
self.failUnless(hasattr(self.driver,'NUMBER'),
840+
self.assertTrue(hasattr(self.driver,'NUMBER'),
841841
'module.NUMBER must be defined.'
842842
)
843843

844844
def test_DATETIME(self):
845-
self.failUnless(hasattr(self.driver,'DATETIME'),
845+
self.assertTrue(hasattr(self.driver,'DATETIME'),
846846
'module.DATETIME must be defined.'
847847
)
848848

849849
def test_ROWID(self):
850-
self.failUnless(hasattr(self.driver,'ROWID'),
850+
self.assertTrue(hasattr(self.driver,'ROWID'),
851851
'module.ROWID must be defined.'
852852
)
853853

MySQLdb/tests/test_MySQLdb_capabilities.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class test_MySQLdb(capabilities.DatabaseTest):
1010

1111
db_module = MySQLdb
1212
connect_args = ()
13-
connect_kwargs = dict(db='test', read_default_file='~/.my.cnf',
13+
connect_kwargs = dict(db='test', host="127.0.0.1", user="test", #read_default_file='~/.my.cnf',
1414
charset='utf8', sql_mode="ANSI,STRICT_TRANS_TABLES,TRADITIONAL")
1515
create_table_extra = "ENGINE=INNODB CHARACTER SET UTF8"
1616
leak_test = False
@@ -78,7 +78,7 @@ def test_bug_2671682(self):
7878
try:
7979
self.cursor.execute("describe some_non_existent_table");
8080
except self.connection.ProgrammingError, msg:
81-
self.failUnless(msg[0] == ER.NO_SUCH_TABLE)
81+
self.assertTrue(msg[0] == ER.NO_SUCH_TABLE)
8282

8383
def test_ping(self):
8484
self.connection.ping()

MySQLdb/tests/test_MySQLdb_dbapi20.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ class test_MySQLdb(dbapi20.DatabaseAPI20Test):
77
driver = MySQLdb
88
connect_args = ()
99
connect_kw_args = dict(db='test',
10-
read_default_file='~/.my.cnf',
10+
host="127.0.0.1",
11+
user="test", #read_default_file='~/.my.cnf',
1112
charset='utf8',
1213
sql_mode="ANSI,STRICT_TRANS_TABLES,TRADITIONAL")
1314

@@ -39,7 +40,7 @@ def test_fetchall(self):
3940

4041
cur.execute('select name from %sbooze' % self.table_prefix)
4142
rows = cur.fetchall()
42-
self.failUnless(cur.rowcount in (-1,len(self.samples)))
43+
self.assertTrue(cur.rowcount in (-1,len(self.samples)))
4344
self.assertEqual(len(rows),len(self.samples),
4445
'cursor.fetchall did not retrieve all rows'
4546
)
@@ -55,12 +56,12 @@ def test_fetchall(self):
5556
'cursor.fetchall should return an empty list if called '
5657
'after the whole result set has been fetched'
5758
)
58-
self.failUnless(cur.rowcount in (-1,len(self.samples)))
59+
self.assertTrue(cur.rowcount in (-1,len(self.samples)))
5960

6061
self.executeDDL2(cur)
6162
cur.execute('select name from %sbarflys' % self.table_prefix)
6263
rows = cur.fetchall()
63-
self.failUnless(cur.rowcount in (-1,0))
64+
self.assertTrue(cur.rowcount in (-1,0))
6465
self.assertEqual(len(rows),0,
6566
'cursor.fetchall should return an empty list if '
6667
'a select query returns no rows'
@@ -88,7 +89,7 @@ def test_fetchone(self):
8889
'cursor.fetchone should return None if a query retrieves '
8990
'no rows'
9091
)
91-
self.failUnless(cur.rowcount in (-1,0))
92+
self.assertTrue(cur.rowcount in (-1,0))
9293

9394
# cursor.fetchone should raise an Error if called after
9495
# executing a query that cannnot return rows
@@ -108,7 +109,7 @@ def test_fetchone(self):
108109
## self.assertEqual(cur.fetchone(),None,
109110
## 'cursor.fetchone should return None if no more rows available'
110111
## )
111-
self.failUnless(cur.rowcount in (-1,1))
112+
self.assertTrue(cur.rowcount in (-1,1))
112113
finally:
113114
con.close()
114115

@@ -125,12 +126,12 @@ def test_rowcount(self):
125126
cur.execute("insert into %sbooze values ('Victoria Bitter')" % (
126127
self.table_prefix
127128
))
128-
## self.failUnless(cur.rowcount in (-1,1),
129+
## self.assertTrue(cur.rowcount in (-1,1),
129130
## 'cursor.rowcount should == number or rows inserted, or '
130131
## 'set to -1 after executing an insert statement'
131132
## )
132133
cur.execute("select name from %sbooze" % self.table_prefix)
133-
self.failUnless(cur.rowcount in (-1,1),
134+
self.assertTrue(cur.rowcount in (-1,1),
134135
'cursor.rowcount should == number of rows returned, or '
135136
'set to -1 after executing a select statement'
136137
)

MySQLdb/tests/test_MySQLdb_nonstandard.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class CoreAPI(unittest.TestCase):
4444
"""Test _mysql interaction internals."""
4545

4646
def setUp(self):
47-
self.conn = _mysql.connect(db='test', read_default_file="~/.my.cnf")
47+
self.conn = _mysql.connect(db='test', host='127.0.0.1', user='test') #read_default_file="~/.my.cnf")
4848

4949
def tearDown(self):
5050
self.conn.close()

0 commit comments

Comments
 (0)