ignore-names: case-sensitive globbing on all platforms (#218)

Author: malsyned

src/pep8ext_naming.py

@@ -3,7 +3,7 @@
 import sys
 from ast import iter_child_nodes
 from collections import deque
-from fnmatch import fnmatch
+from fnmatch import fnmatchcase
 from functools import partial
 from itertools import chain
 
@@ -68,7 +68,7 @@ def _err(self, node, code, **kwargs):
 
 
 def _ignored(name, ignore):
-    return any(fnmatch(name, i) for i in ignore)
+    return any(fnmatchcase(name, i) for i in ignore)
 
 
 BaseASTCheck = _ASTCheckMeta('BaseASTCheck', (object,),

testsuite/N801.py

@@ -5,6 +5,9 @@ class notok:
 class notok:
     pass
 #: Okay(--ignore-names=*ok)
+class notok:
+    pass
+#: N801:1:7(--ignore-names=*OK)
 class notok:
     pass
 #: N801

testsuite/N802.py

@@ -23,6 +23,9 @@ def NotOK():
 def NotOK():
     pass
 #: Okay(--ignore-names=*OK)
+def NotOK():
+    pass
+#: N802:1:5(--ignore-names=*ok)
 def NotOK():
     pass
 #: Okay

testsuite/N803.py

@@ -40,6 +40,9 @@ def b13(BAD, *VERYBAD, **EXTRABAD):
 #: Okay(--ignore-names=*BAD)
 def b13(BAD, *VERYBAD, **EXTRABAD):
     pass
+#: N803:1:9(--ignore-names=*bad)
+def b13(BAD):
+    pass
 #: N803:1:9
 def b14(BAD):
     pass

testsuite/N804.py

@@ -17,6 +17,11 @@ def test(self, ads):
     def __init_subclass(self, ads):
         pass
 #: Okay(--ignore-names=klass)
+class SpecialConventionCase:
+    @classmethod
+    def prepare_meta(klass, root):
+        pass
+#: N804(--ignore-names=KLASS)
 class SpecialConventionCase:
     @classmethod
     def prepare_meta(klass, root):

testsuite/N805.py

@@ -23,6 +23,10 @@ class Foo:
     def bad(ads, self):
         pass
 #: Okay(--ignore-names=source)
+class GraphQLNode:
+    def resolve_foo(source, info):
+        pass
+#: N805(--ignore-names=SOURCE)
 class GraphQLNode:
     def resolve_foo(source, info):
         pass

testsuite/N806.py

@@ -29,6 +29,9 @@ def test():
 def test():
     Bad = 1
 #: Okay(--ignore-names=B*)
+def test():
+    Bad = 1
+#: N806(--ignore-names=b*)
 def test():
     Bad = 1
 #: Okay

testsuite/N807.py

@@ -50,6 +50,9 @@ def __bad__():
 def __bad__():
     pass
 #: Okay(--ignore-names=__*)
+def __bad__():
+    pass
+#: N807(--ignore-names=__B*)
 def __bad__():
     pass
 #: Okay

testsuite/N815.py

@@ -25,3 +25,6 @@ class C:
 #: Okay(--ignore-names=*Case)
 class C:
     mixed_Case = 0
+#: N815(--ignore-names=*case)
+class C:
+    mixed_Case = 0

testsuite/N816.py

@@ -22,6 +22,8 @@
 mixedCase = 0
 #: Okay(--ignore-names=*Case)
 mixedCase = 0
+#: N816(--ignore-names=*case)
+mixedCase = 0
 #: Okay
 Γ = 1
 #: N816