Skip to content

Commit 19001f7

Browse files
authored
Merge pull request #1966 from PyCQA/limit-procs-to-file-count
avoid starting unnecessary processes when file count is limited
2 parents cf1542c + f35737a commit 19001f7

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

src/flake8/checker.py

+1
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,7 @@ def start(self) -> None:
256256
exclude=self.exclude,
257257
)
258258
)
259+
self.jobs = min(len(self.filenames), self.jobs)
259260

260261
def stop(self) -> None:
261262
"""Stop checking files."""

tests/unit/test_checker_manager.py

+10
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,16 @@ def test_multiprocessing_cpu_count_not_implemented():
6161
assert manager.jobs == 0
6262

6363

64+
def test_jobs_count_limited_to_file_count():
65+
style_guide = style_guide_mock()
66+
style_guide.options.jobs = JobsArgument("4")
67+
style_guide.options.filenames = ["file1", "file2"]
68+
manager = checker.Manager(style_guide, finder.Checkers([], [], []), [])
69+
assert manager.jobs == 4
70+
manager.start()
71+
assert manager.jobs == 2
72+
73+
6474
def test_make_checkers():
6575
"""Verify that we create a list of FileChecker instances."""
6676
style_guide = style_guide_mock()

0 commit comments

Comments
 (0)