Check binding signature details against primary key (#264)

twiss · web-flow · commit d703f494c90d · 2025-01-15T14:30:53.000+01:00
Rather than checking the binding signature details against the subkey 
(i.e. the subject of the binding signature), check them against the primary key (i.e. the signing key).
diff --git a/openpgp/v2/subkeys.go b/openpgp/v2/subkeys.go
@@ -187,7 +187,7 @@ func (s *Subkey) LatestValidBindingSignature(date time.Time, config *packet.Conf
 			if sig.Valid == nil {
 				err := s.Primary.PrimaryKey.VerifyKeySignature(s.PublicKey, sig.Packet)
 				if err == nil {
-					err = checkSignatureDetails(s.PublicKey, sig.Packet, date, config)
+					err = checkSignatureDetails(s.Primary.PrimaryKey, sig.Packet, date, config)
 				}
 				valid := err == nil
 				sig.Valid = &valid

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ func (s Subkey) LatestValidBindingSignature(date time.Time, config packet.Conf`
`187`	`187`	`if sig.Valid == nil {`
`188`	`188`	`err := s.Primary.PrimaryKey.VerifyKeySignature(s.PublicKey, sig.Packet)`
`189`	`189`	`if err == nil {`
`190`		`- err = checkSignatureDetails(s.PublicKey, sig.Packet, date, config)`
	`190`	`+ err = checkSignatureDetails(s.Primary.PrimaryKey, sig.Packet, date, config)`
`191`	`191`	`}`
`192`	`192`	`valid := err == nil`
`193`	`193`	`sig.Valid = &valid`