Skip to content

Commit 243f49e

Browse files
authored
refactor: replace NativeScriptModule with NativeScriptCommonModule (#97)
NativeScriptModule should be imported only in the root NgModule. For all other feature modules, NativeScriptCommonModule should be used instead. Check out NativeScript/nativescript-angular#1196.
1 parent e1a1141 commit 243f49e

File tree

7 files changed

+26
-26
lines changed

7 files changed

+26
-26
lines changed

Diff for: sdkAngular/app/autocomplete/autocomplete-examples.module.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33

44
import { NativeScriptRouterModule } from "nativescript-angular/router";
55
import { NativeScriptUIAutoCompleteTextViewModule } from "nativescript-ui-autocomplete/angular";
@@ -28,11 +28,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
2828
@NgModule({
2929
schemas: [NO_ERRORS_SCHEMA],
3030
imports: [
31-
NativeScriptModule,
3231
CommonDirectivesModule,
3332
NativeScriptUIAutoCompleteTextViewModule,
3433
NativeScriptRouterModule,
35-
NativeScriptRouterModule.forChild(routes)
34+
NativeScriptRouterModule.forChild(routes),
35+
NativeScriptCommonModule,
3636
],
3737
declarations: [
3838
AutoCompleteContainsModeComponent,

Diff for: sdkAngular/app/calendar/calendar-examples.module.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33

44
import { NativeScriptRouterModule } from "nativescript-angular/router";
55
import { NativeScriptUICalendarModule } from "nativescript-ui-calendar/angular";
@@ -21,12 +21,12 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
2121
@NgModule({
2222
schemas: [NO_ERRORS_SCHEMA],
2323
imports: [
24-
NativeScriptModule,
2524
CommonDirectivesModule,
2625
NativeScriptUICalendarModule,
2726
NativeScriptUIListViewModule,
2827
NativeScriptRouterModule,
29-
NativeScriptRouterModule.forChild(routes)
28+
NativeScriptRouterModule.forChild(routes),
29+
NativeScriptCommonModule,
3030
],
3131
declarations: [
3232
CalendarLocalizationComponent,

Diff for: sdkAngular/app/chart/chart-examples.module.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33

44
import { NativeScriptRouterModule } from "nativescript-angular/router";
55
import { NativeScriptUIChartModule } from "nativescript-ui-chart/angular";
@@ -44,11 +44,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
4444
@NgModule({
4545
schemas: [NO_ERRORS_SCHEMA],
4646
imports: [
47-
NativeScriptModule,
4847
CommonDirectivesModule,
4948
NativeScriptUIChartModule,
5049
NativeScriptRouterModule,
51-
NativeScriptRouterModule.forChild(routes)
50+
NativeScriptRouterModule.forChild(routes),
51+
NativeScriptCommonModule,
5252
],
5353
declarations: [
5454
ChartAnnotationsGridLineComponent,
@@ -86,4 +86,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
8686
ChartLabelVisibilityComponent
8787
]
8888
})
89-
export class ChartExamplesModule { }
89+
export class ChartExamplesModule { }

Diff for: sdkAngular/app/dataform/dataform-examples.module.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33

44
import { NativeScriptRouterModule } from "nativescript-angular/router";
55
import { NativeScriptUIDataFormModule } from "nativescript-ui-dataform/angular";
@@ -42,11 +42,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
4242
@NgModule({
4343
schemas: [NO_ERRORS_SCHEMA],
4444
imports: [
45-
NativeScriptModule,
4645
CommonDirectivesModule,
4746
NativeScriptUIDataFormModule,
4847
NativeScriptRouterModule,
49-
NativeScriptRouterModule.forChild(routes)
48+
NativeScriptRouterModule.forChild(routes),
49+
NativeScriptCommonModule,
5050
],
5151
declarations: [
5252
DataFormAdjustmentComponent,
@@ -82,4 +82,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
8282
DataFormValueProvidersComponent,
8383
]
8484
})
85-
export class DataFormExamplesModule { }
85+
export class DataFormExamplesModule { }

Diff for: sdkAngular/app/gauges/gauges-examples.module.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33

44
import { NativeScriptRouterModule } from "nativescript-angular/router";
55
import { NativeScriptUIGaugeModule } from "nativescript-ui-gauge/angular";
@@ -15,11 +15,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
1515
@NgModule({
1616
schemas: [NO_ERRORS_SCHEMA],
1717
imports: [
18-
NativeScriptModule,
1918
CommonDirectivesModule,
2019
NativeScriptUIGaugeModule,
2120
NativeScriptRouterModule,
22-
NativeScriptRouterModule.forChild(routes)
21+
NativeScriptRouterModule.forChild(routes),
22+
NativeScriptCommonModule,
2323
],
2424
declarations: [
2525
GaugesAnimationsComponent,
@@ -28,4 +28,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
2828
GaugesScalesComponent
2929
]
3030
})
31-
export class GaugesExamplesModule { }
31+
export class GaugesExamplesModule { }

Diff for: sdkAngular/app/listview/listview-examples.module.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33

44
import { NativeScriptRouterModule } from "nativescript-angular/router";
55
import { NativeScriptFormsModule } from "nativescript-angular/forms";
@@ -46,12 +46,12 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
4646
@NgModule({
4747
schemas: [NO_ERRORS_SCHEMA],
4848
imports: [
49-
NativeScriptModule,
5049
CommonDirectivesModule,
5150
NativeScriptUIListViewModule,
5251
NativeScriptFormsModule,
5352
NativeScriptRouterModule,
54-
NativeScriptRouterModule.forChild(routes)
53+
NativeScriptRouterModule.forChild(routes),
54+
NativeScriptCommonModule,
5555
],
5656
declarations: [
5757
ListViewGettingStartedComponent,
@@ -90,4 +90,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
9090
ListViewDataOperationsSortingComponent
9191
]
9292
})
93-
export class ListViewExamplesModule { }
93+
export class ListViewExamplesModule { }

Diff for: sdkAngular/app/sidedrawer/sidedrawer-examples.module.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33

44
import { NativeScriptRouterModule } from "nativescript-angular/router";
55
import { NativeScriptUISideDrawerModule } from "nativescript-ui-sidedrawer/angular";
@@ -17,11 +17,11 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
1717
@NgModule({
1818
schemas: [NO_ERRORS_SCHEMA],
1919
imports: [
20-
NativeScriptModule,
2120
CommonDirectivesModule,
2221
NativeScriptUISideDrawerModule,
2322
NativeScriptRouterModule,
24-
NativeScriptRouterModule.forChild(routes)
23+
NativeScriptRouterModule.forChild(routes),
24+
NativeScriptCommonModule,
2525
],
2626
declarations: [
2727
SideDrawerEventsComponent,
@@ -32,4 +32,4 @@ import { CommonDirectivesModule } from '../navigation/directives/common-directiv
3232
SideDrawerTransitionsComponent
3333
]
3434
})
35-
export class SideDrawerExamplesModule { }
35+
export class SideDrawerExamplesModule { }

0 commit comments

Comments
 (0)